JAkutenshi commented on code in PR #5465: URL: https://github.com/apache/ignite-3/pull/5465#discussion_r2010243916
########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ########## @@ -251,6 +256,8 @@ public class PartitionReplicaLifecycleManager extends * @param sharedTxStateStorage Shared tx state storage. * @param txManager Transaction manager. * @param schemaManager Schema manager. + * @param dataStorageManager Data storage manager for checking zones' storage profiles for volatile flag. Review Comment: Mostly I'd like to read a motivation under one-time added dependencies to be sure when I want to delete them that there no any other reasons to keep them. But it's opinionated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org