AMashenkov commented on code in PR #5454:
URL: https://github.com/apache/ignite-3/pull/5454#discussion_r2010656316
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/LogicalRelImplementor.java:
##########
@@ -377,37 +384,37 @@ public Node<RowT> visit(IgniteMergeJoin rel) {
SqlJoinProjection<RowT> joinProjection = createJoinProjection(rel,
rel.getRowType(), leftType.getFieldCount());
- int pairsCnt = rel.analyzeCondition().pairs().size();
+ ImmutableBitSet nullCompAsEqual = nullComparisonStrategyVector(rel,
rel.analyzeCondition().leftSet());
- ImmutableBitSet leftKeys = rel.analyzeCondition().leftSet();
+ ImmutableIntList leftKeys = rel.leftCollation().getKeys();
+ ImmutableIntList rightKeys = rel.rightCollation().getKeys();
- List<RexNode> conjunctions =
RelOptUtil.conjunctions(rel.getCondition());
+ // Convert conditions to using collation indexes instead of field
indexes.
+ List<IntPair> condIndexes = rel.analyzeCondition().pairs().stream()
Review Comment:
Rewritten with for-loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
