rpuch commented on code in PR #5491: URL: https://github.com/apache/ignite-3/pull/5491#discussion_r2011426614
########## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteStripedBusyLock.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.util; + +/** + * Busy lock implementation based on {@link IgniteStripedBusyLock}. API is analogous to {@link IgniteSpinBusyLock}, but without the ability + * to unblock it. + */ +public class IgniteStripedBusyLock { + /** Underlying read-write lock. */ + private final IgniteStripedReadWriteLock lock = new IgniteStripedReadWriteLock(); + + private volatile boolean blocked = false; + + /** + * Enters "busy" state. + * + * @return {@code true} if entered to busy state. + */ + public boolean enterBusy() { + if (blocked || !lock.readLock().tryLock()) { Review Comment: Why is the check that the RW lock is write-locked by the current thread is removed? ########## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteStripedBusyLock.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.util; + +/** + * Busy lock implementation based on {@link IgniteStripedBusyLock}. API is analogous to {@link IgniteSpinBusyLock}, but without the ability + * to unblock it. + */ +public class IgniteStripedBusyLock { + /** Underlying read-write lock. */ + private final IgniteStripedReadWriteLock lock = new IgniteStripedReadWriteLock(); + + private volatile boolean blocked = false; + + /** + * Enters "busy" state. + * + * @return {@code true} if entered to busy state. + */ + public boolean enterBusy() { + if (blocked || !lock.readLock().tryLock()) { + return false; + } + + if (blocked) { + leaveBusy(); + + return false; + } + + return true; + } + + /** + * Leaves "busy" state. + */ + public void leaveBusy() { + lock.readLock().unlock(); + } + + /** + * Blocks current thread till all activities left "busy" state and prevents them from further entering to "busy" state. Review Comment: ```suggestion * Blocks current thread till all activities left "busy" state and prevents them from further entering the "busy" state. ``` ########## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteStripedBusyLock.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.util; + +/** + * Busy lock implementation based on {@link IgniteStripedBusyLock}. API is analogous to {@link IgniteSpinBusyLock}, but without the ability Review Comment: So this implementation is based on itself? Probably not what was meant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
