sanpwc commented on code in PR #5597:
URL: https://github.com/apache/ignite-3/pull/5597#discussion_r2036793762
##########
modules/transactions/src/integrationTest/java/org/apache/ignite/tx/distributed/ItTransactionRecoveryTest.java:
##########
@@ -630,7 +650,9 @@ public void testCommitAndDieRecoveryFirst() throws
Exception {
public void testRecoveryIsTriggeredOnce() throws Exception {
TableImpl tbl = unwrapTableImpl(node(0).tables().table(TABLE_NAME));
- var tblReplicationGrp = new TablePartitionId(tbl.tableId(), PART_ID);
+ var tblReplicationGrp = enabledColocation()
Review Comment:
It's intended to be like this. When we will remove non-colocated code
```
var tblReplicationGrp = enabledColocation()
? new ZonePartitionId(tbl.zoneId(), PART_ID)
: new TablePartitionId(tbl.tableId(), PART_ID);
```
will be converted to
`var tblReplicationGrp = new ZonePartitionId(tbl.zoneId(), PART_ID);`
without extra effort.
In case of helper method it'll look like
```
var tblReplicationGrp = replicationGroupId(tbl, PART_ID);
```
and the method
```
private static @NotNull PartitionGroupId getPartitionGroupId(TableImpl
tbl, int partitionId) {
return enabledColocation()
? new ZonePartitionId(tbl.zoneId(), partitionId)
: new TablePartitionId(tbl.tableId(), partitionId);
}
```
```
will be converted to
private static @NotNull PartitionGroupId getPartitionGroupId(TableImpl
tbl, int partitionId) {
return new ZonePartitionId(tbl.zoneId(), partitionId);
}
```
and thus should be removed.
Should I introduce the method that will be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
