nizhikov commented on code in PR #12002:
URL: https://github.com/apache/ignite/pull/12002#discussion_r2046732744
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/tracker/ObjectSizeCalculator.java:
##########
@@ -112,11 +98,10 @@ private static long calcAlign() {
// Binary objects.
// Assume objects is not deserialized.
- addSysClsSize(BinaryObjectImpl.class, (c, bo) -> align(byteArrOffset +
bo.array().length));
- addSysClsSize(BinaryObjectOffheapImpl.class, null); // No extra heap
memory.
Review Comment:
Yes, we can. But this will still keep link between `ObjectSizeCalculator`
and binary in the form of class FQDN.
But, current version of PR reduce link to simple, understable methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
