shishkovilja commented on code in PR #12001:
URL: https://github.com/apache/ignite/pull/12001#discussion_r2056397712


##########
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java:
##########
@@ -662,7 +630,7 @@ public static boolean isBinaryType(Class<?> cls) {
 
         return BinaryObject.class.isAssignableFrom(cls) ||
             Proxy.class.isAssignableFrom(cls) ||
-            BINARY_CLS.contains(cls);
+            FLAG_TO_CLASS.containsValue(cls);

Review Comment:
   We can get performance drop here, because`Map#containsValue`JavaDoc says:
   > This operation will probably require time linear in the map size for most 
implementations of the {@code Map} interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to