alievmirza commented on code in PR #5726:
URL: https://github.com/apache/ignite-3/pull/5726#discussion_r2068625725
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1190,6 +1211,16 @@ private CompletableFuture<Void>
handleChangePendingAssignmentEvent(Entry pending
return nullCompletedFuture();
}
+ // A node might exist in stable yet we don't want to start the
replica
Review Comment:
Why do we have the same code here and in
`handleChangePendingAssignmentEvent`?
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java:
##########
@@ -599,11 +599,37 @@ public static List<Assignments> zoneAssignmentsGetLocally(
) {
return IntStream.range(0, numberOfPartitions)
.mapToObj(p -> {
- Entry e =
metaStorageManager.getLocally(stablePartAssignmentsKey(new
ZonePartitionId(zoneId, p)), revision);
+ Assignments assignments =
+
zoneStableAssignmentsGetLocally(metaStorageManager, new ZonePartitionId(zoneId,
p), revision);
+
+ assert assignments != null
Review Comment:
what is the purpose of part after `:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
