chesnokoff commented on code in PR #11986:
URL: https://github.com/apache/ignite/pull/11986#discussion_r2077262127
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/persistence/SnapshotCompatibilityTest.java:
##########
@@ -142,19 +134,35 @@ public void setUp() {
/** */
@Test
public void testSnapshotRestore() throws Exception {
+ if (incSnp) {
+ assumeFalse("Incremental snapshots for cache dump not supported",
cacheDump);
+
+ assumeTrue("Incremental snapshots require same consistentID",
customConsId);
+
+ assumeTrue("https://issues.apache.org/jira/browse/IGNITE-25096";,
oldNodesCnt == 1);
+ }
+
try {
+ for (int i = 1; i < oldNodesCnt; ++i) {
+ startGrid(
+ i,
+ OLD_IGNITE_VERSION,
+ new ConfigurationClosure(incSnp, consId(i), customSnpPath,
true, cacheGrpInfo)
+ );
+ }
+
startGrid(
oldNodesCnt,
OLD_IGNITE_VERSION,
- new ConfigurationClosure(incSnp, consId, customSnpPath, true,
cacheGrpInfo),
+ new ConfigurationClosure(incSnp, consId(oldNodesCnt),
customSnpPath, true, cacheGrpInfo),
new CreateSnapshotClosure(incSnp, cacheDump, cacheGrpInfo)
);
Review Comment:
What about just passing `null` as fourth argument of `startGrid` when it
needed? Then you could merge this two types of grid starting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
