valepakh commented on code in PR #5685:
URL: https://github.com/apache/ignite-3/pull/5685#discussion_r2077378948
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/storage/CatalogSerializationCompatibilityTest.java:
##########
@@ -393,7 +400,10 @@ private <T extends UpdateLogEvent> T checkEntry(Class<T>
entryClass, String entr
log.info("Read fileName: {}, class: {}, version: {}", fileName,
entryClass.getSimpleName(), version);
- UpdateLogMarshallerImpl marshaller = new
UpdateLogMarshallerImpl(provider, protocolVersion());
+ UpdateLogMarshaller marshaller = new UpdateLogMarshallerImpl(provider,
protocolVersion());
+
+ // Uncomment this and run tests with corresponding entryVersion to
write entry to file
+ // writeEntry(entry, resourceName, marshaller);
Review Comment:
Yes, to have the ability to quickly generate new binary test cases in the
future.
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java:
##########
@@ -61,6 +62,9 @@ public class CatalogUtils {
/** Default number of distribution zone replicas. */
public static final int DEFAULT_REPLICA_COUNT = 1;
+ /** Default quorum size. */
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
