rpuch commented on code in PR #5782:
URL: https://github.com/apache/ignite-3/pull/5782#discussion_r2079394499
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/PartitionScanPublisher.java:
##########
@@ -233,8 +233,9 @@ private CompletableFuture<Void> retrieveAndProcessBatch() {
}
private void processBatch(Collection<T> batch, int requestedCnt) {
- assert batch != null;
- assert batch.size() <= requestedCnt : "Rows more than requested "
+ batch.size() + " " + requestedCnt;
+ assert batch != null : "Batch is null";
Review Comment:
If an assert without a message gets triggered, it produces an AssertionError
in which getMessage() returns null. If then this error gets wrapped in
IgniteInternalException, it will also contain null as getMessage(). As a
result, the final exception will also have no message at all, so it might be
really difficult to find the root cause in logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
