alievmirza commented on code in PR #5761:
URL: https://github.com/apache/ignite-3/pull/5761#discussion_r2079992159
##########
modules/transactions/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java:
##########
@@ -1358,8 +1355,13 @@ void testAssignmentsChainUpdate() throws Exception {
stopNodesInParallel(1, 2);
DisasterRecoveryManager disasterRecoveryManager =
node0.disasterRecoveryManager();
- CompletableFuture<?> updateFuture =
- disasterRecoveryManager.resetTablePartitions(zoneName,
SCHEMA_NAME, TABLE_NAME, emptySet(), true, -1);
+
+ CompletableFuture<?> updateFuture;
+ if (enabledColocation()) {
Review Comment:
We have `TestDisasterRecoveryUtils.resetPartitions` for such purposes
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java:
##########
@@ -104,6 +105,10 @@ public class ZoneRebalanceUtil {
static final byte[] ZONE_PENDING_CHANGE_TRIGGER_PREFIX_BYTES =
ZONE_PENDING_CHANGE_TRIGGER_PREFIX.getBytes(UTF_8);
+ public static final String ZONE_ASSIGNMENTS_CHAIN_PREFIX =
"zone.assignments.chain.";
+
+ public static final byte[] ASSIGNMENTS_CHAIN_PREFIX_BYTES =
ZONE_ASSIGNMENTS_CHAIN_PREFIX.getBytes(UTF_8);
Review Comment:
This field is not used, let's remove this along with the `RebalanceUtil`
version
##########
modules/transactions/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java:
##########
@@ -1285,8 +1284,6 @@ void testTwoPhaseResetOnEmptyNodes() throws Exception {
@Test
@ZoneParams(nodes = 7, replicas = 3, partitions = 1, consistencyMode =
ConsistencyMode.HIGH_AVAILABILITY)
- // TODO https://issues.apache.org/jira/browse/IGNITE-24144
- @WithSystemProperty(key = COLOCATION_FEATURE_FLAG, value = "false")
Review Comment:
I would be grateful if you check also `@Disabled` tests regarding chain
logic. They must fail with the same reason as they failed when colocation flag
set to false. I've checked several, they pass, but I could miss something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
