xtern commented on code in PR #5750:
URL: https://github.com/apache/ignite-3/pull/5750#discussion_r2080965996


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -543,6 +550,32 @@ public static Object consumeFirstArgument(Object args0, 
Object args1) {
         return args1;
     }
 
+    /** Converts timestamp string into a timestamp with local time zone. */
+    public static @Nullable Long toTimestampWithLocalTimeZone(@Nullable String 
v, TimeZone timeZone) {

Review Comment:
   Maybe I'm missing something.
   But, цhy do we need to define an Ignite method that uses the Calcite 
implementation and, even more strangely, add a test that does exactly the same 
thing as the method itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to