AMashenkov commented on code in PR #5888:
URL: https://github.com/apache/ignite-3/pull/5888#discussion_r2104463481
##########
modules/core/src/test/java/org/apache/ignite/internal/util/IgniteNameUtilsTest.java:
##########
@@ -165,4 +167,38 @@ private static List<Arguments> parseNameIllegalArguments()
{
Arguments.of("foo..", "Malformed identifier [identifier=foo..,
pos=4]")
);
}
+
+ @ParameterizedTest
+ @MethodSource("parseAndNormalizeData")
+ public void parseAndNormalize(String input, String result) {
+ String actual = IgniteNameUtils.parseAndNormalize(input);
+ assertEquals(result, actual);
+ }
+
+ private static Stream<Arguments> parseAndNormalizeData() {
+ return Stream.of(
+ Arguments.of("foo", "FOO"),
+ Arguments.of("Foo", "FOO"),
+ Arguments.of("fOo", "FOO"),
+ Arguments.of("f_oo", "F_OO"),
+ Arguments.of("_foo", "_FOO"),
+ Arguments.of("foo_", "FOO_"),
+ Arguments.of("_foo_", "_FOO_"),
+
+ Arguments.of("foo1", "FOO1"),
+ Arguments.of("foo-1", "\"foo-1\""),
+ Arguments.of("foo_1", "FOO_1"),
+ Arguments.of("1foo", "\"1foo\""),
+ Arguments.of("1_foo", "\"1_foo\""),
+
+ Arguments.of("a bar", "\"a bar\""),
+ Arguments.of("A bar", "\"A bar\""),
+ Arguments.of("A.bar", "\"A.bar\""),
+
+ Arguments.of("\"a bar\"", "\"a bar\""),
+ Arguments.of("\"_a bar\"", "\"_a bar\""),
+ Arguments.of("\"a bar", "\"\"\"a bar\""),
+ Arguments.of("\"_a bar", "\"\"\"_a bar\"")
Review Comment:
Here is ambiguity between case-sensitive name and quoted names.
`\"a bar\"` is translated to itself `\"a bar\"` as case-sensitive name, but
never to quoted `\"\"a bar\"\"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
