ibessonov commented on code in PR #5886:
URL: https://github.com/apache/ignite-3/pull/5886#discussion_r2106734796
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationRegistry.java:
##########
@@ -118,6 +124,12 @@ public InnerNode createRootNode(RootKey<?, ?> rootKey) {
public CompletableFuture<Void> startAsync(ComponentContext
componentContext) {
changer.start();
+ // Initialize local configuration on start so that it can be read and
modified during component start.
+ // Distributed configuration will be initialized during the
"notifyCurrentConfigurationListeners" call.
+ if (configurationType == ConfigurationType.LOCAL) {
Review Comment:
Can it be done outside of `startAsync`?
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/storageprofile/ItStorageProfilesTest.java:
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.storageprofile;
+
+import static org.apache.ignite.internal.TestWrappers.unwrapIgniteImpl;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.notNullValue;
+
+import com.typesafe.config.parser.ConfigDocument;
+import com.typesafe.config.parser.ConfigDocumentFactory;
+import org.apache.ignite.configuration.NamedListView;
+import org.apache.ignite.internal.ClusterPerClassIntegrationTest;
+import org.apache.ignite.internal.app.IgniteImpl;
+import
org.apache.ignite.internal.pagememory.configuration.schema.PersistentPageMemoryProfileView;
+import
org.apache.ignite.internal.pagememory.configuration.schema.VolatilePageMemoryProfileView;
+import
org.apache.ignite.internal.storage.configurations.StorageExtensionConfiguration;
+import org.apache.ignite.internal.storage.configurations.StorageProfileView;
+import org.apache.ignite.internal.storage.engine.StorageEngine;
+import
org.apache.ignite.internal.storage.pagememory.PersistentPageMemoryStorageEngine;
+import
org.apache.ignite.internal.storage.pagememory.VolatilePageMemoryStorageEngine;
+import org.apache.ignite.internal.storage.rocksdb.RocksDbStorageEngine;
+import
org.apache.ignite.internal.storage.rocksdb.configuration.schema.RocksDbProfileView;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Test class for validating storage profiles configuration.
+ */
+public class ItStorageProfilesTest extends ClusterPerClassIntegrationTest {
+ private static final String AIPERSIST_PROFILE_NAME =
ItStorageProfilesTest.class.getSimpleName() + "_aipersist";
+ private static final String AIMEM_PROFILE_NAME =
ItStorageProfilesTest.class.getSimpleName() + "_aimem";
+ private static final String ROCKSDB_PROFILE_NAME =
ItStorageProfilesTest.class.getSimpleName() + "_rocksdb";
+
+ @Override
+ protected int initialNodes() {
+ return 1;
+ }
+
+ @Override
+ protected String getNodeBootstrapConfigTemplate() {
+ ConfigDocument document =
ConfigDocumentFactory.parseString(super.getNodeBootstrapConfigTemplate());
Review Comment:
I wish we had something like this:
```
@NodeConfig(key = "ignite.storage.profiles.name.size", value = "-1");
```
It's unrelated to your PR though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
