nizhikovprivate commented on code in PR #11969:
URL: https://github.com/apache/ignite/pull/11969#discussion_r2108661751
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/persistence/SnapshotCompatibilityTest.java:
##########
@@ -209,37 +179,29 @@ private void checkCacheDump(IgniteEx node) throws
IgniteCheckedException {
}
@Override public void onCacheConfigs(Iterator<StoredCacheData>
caches) {
- assertNotNull(cacheGrpInfo);
-
caches.forEachRemaining(cache -> {
CacheConfiguration<?, ?> ccfg = cache.config();
assertNotNull(ccfg);
- assertEquals(cacheGrpInfo.name(), ccfg.getGroupName());
-
- foundCacheNames.add(ccfg.getName());
+ foundCacheGrpsInfo.addCache(ccfg.getGroupName(),
ccfg.getName());
});
}
@Override public void onPartition(int grp, int part,
Iterator<DumpEntry> data) {
- assertNotNull(cacheGrpInfo);
+ data.forEachRemaining(dumpEntry -> {
+ assertNotNull(dumpEntry);
- data.forEachRemaining(de -> {
- assertNotNull(de);
+ Integer key = (Integer)dumpEntry.key();
+ String val = (String)dumpEntry.value();
- Integer key = (Integer)de.key();
- String val = (String)de.value();
+ Optional<String> cacheName =
cacheGrpsCfg.cacheNames().stream().filter(val::startsWith).findFirst();
Review Comment:
Any reason to use `startsWith`? Looks like we must use `equals` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
