ibessonov commented on code in PR #5968:
URL: https://github.com/apache/ignite-3/pull/5968#discussion_r2123593414
##########
modules/metastorage-api/src/test/java/org/apache/ignite/internal/metastorage/dsl/ConditionTypeTest.java:
##########
@@ -19,85 +19,57 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.params.provider.Arguments.arguments;
+import java.util.stream.Stream;
import org.apache.ignite.internal.network.NetworkMessage;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
/**
* Tests that persisted enum ordinals have not been accidentally changed by a
developer.
Review Comment:
```suggestion
* Tests that persisted enum IDs have not been accidentally changed by a
developer.
```
##########
modules/metastorage-api/src/test/java/org/apache/ignite/internal/metastorage/dsl/ConditionTypeTest.java:
##########
@@ -19,85 +19,57 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.params.provider.Arguments.arguments;
+import java.util.stream.Stream;
import org.apache.ignite.internal.network.NetworkMessage;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
/**
* Tests that persisted enum ordinals have not been accidentally changed by a
developer.
Review Comment:
Such a comment is present in multiple tests
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/serialization/MessageDeserializerGenerator.java:
##########
@@ -176,7 +176,7 @@ private MethodSpec readMessageMethod(MessageClass message,
FieldSpec msgField) {
method
.addStatement(
"$T tmp = ordinalShifted == 0 ? null :
$T.$L(ordinalShifted - 1)",
Review Comment:
Theoretically, you could have renamed this variable too, both here and in a
seralizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
