lowka opened a new pull request, #5998: URL: https://github.com/apache/ignite-3/pull/5998
Adds SqlDateTimeParser for TIME/DATE/TIMESTAMP based on the date time format parser introduced in https://github.com/apache/ignite-3/pull/5943. Moves validation logic from the parsing stage. This validation logic is now mostly done by java.time code, so error messages are now similar to java.time ones: Invalid value for HourOfDay (valid range 0 - 23): 99 . - Updates ParsedFields to include methods to retrieve time (LocalTime) / date (LocalDate) / timestamp (LocalDateTime) - Replaces DateTimeFormatException with java.time.DateTimeException to reduce the number of intermediate exceptions https://issues.apache.org/jira/browse/IGNITE-25604 --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
