sashapolo commented on code in PR #5993:
URL: https://github.com/apache/ignite-3/pull/5993#discussion_r2131880733
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1410,13 +1410,14 @@ private CatalogZoneDescriptor zoneDescriptorAt(int
zoneId, long timestamp) {
return zoneDescriptor;
}
- private CompletableFuture<Void> changePeersOnRebalance(
+ private void changePeersOnRebalance(
ReplicaManager replicaMgr,
ZonePartitionId replicaGrpId,
Set<Assignment> pendingAssignments,
long revision
) {
- return replicaMgr.replica(replicaGrpId)
+ // According to the rebalance logic, it's safe to react on pending
assignments change in a async manner.
Review Comment:
```suggestion
// According to the rebalance logic, it's safe to react to pending
assignments change in async manner.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
