timoninmaxim commented on code in PR #12043:
URL: https://github.com/apache/ignite/pull/12043#discussion_r2149647830
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderExImpl.java:
##########
@@ -1991,11 +1991,9 @@ BinarySchema getOrCreateSchema() {
if (schema == null) {
if (fieldIdLen != BinaryUtils.FIELD_ID_LEN) {
- BinaryTypeImpl type = (BinaryTypeImpl)ctx.metadata(typeId,
schemaId);
Review Comment:
Why not BinaryType?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/IgniteCacheObjectProcessor.java:
##########
@@ -274,6 +275,12 @@ public void updateMetadata(int typeId, String typeName,
@Nullable String affKeyF
*/
@Nullable public BinaryType metadata(int typeId) throws IgniteException;
+ /**
+ * @param typeId Type ID.
+ * @return Metadata.
+ * @throws IgniteException In case of error.
+ */
+ @Nullable public BinaryMetadata metadata0(int typeId) throws
IgniteException;
Review Comment:
Naming looks wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
