Copilot commented on code in PR #6058:
URL: https://github.com/apache/ignite-3/pull/6058#discussion_r2151740350
##########
modules/platforms/cpp/ignite/client/table/qualified_name_test.cpp:
##########
@@ -24,6 +24,10 @@
using namespace ignite;
using namespace detail;
+template<typename T>
+std::string PrintTestIndex(const testing::TestParamInfo<typename
T::ParamType>& info) {
+ return "_" + std::to_string(info.index);
+}
Review Comment:
[nitpick] Consider placing `PrintTestIndex` in an anonymous namespace or
marking it `static` to prevent potential ODR/linkage conflicts.
```suggestion
namespace {
template<typename T>
std::string PrintTestIndex(const testing::TestParamInfo<typename
T::ParamType>& info) {
return "_" + std::to_string(info.index);
}
} // namespace
```
##########
modules/platforms/cpp/ignite/client/detail/table/name_utils_test.cpp:
##########
@@ -24,6 +24,11 @@
using namespace ignite;
using namespace detail;
+template<typename T>
+std::string PrintTestIndex(const testing::TestParamInfo<typename
T::ParamType>& info) {
+ return "_" + std::to_string(info.index);
+}
Review Comment:
[nitpick] Consider placing `PrintTestIndex` in an anonymous namespace or
marking it `static` to prevent potential ODR/linkage conflicts.
```suggestion
namespace {
template<typename T>
std::string PrintTestIndex(const testing::TestParamInfo<typename
T::ParamType>& info) {
return "_" + std::to_string(info.index);
}
} // namespace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
