alex-plekhanov commented on code in PR #12037:
URL: https://github.com/apache/ignite/pull/12037#discussion_r2152600525


##########
modules/calcite/src/test/sql/join/inner/join_cross_product.test:
##########
@@ -35,5 +35,8 @@ select * from t1 join t2 on (i=j), t3 join t4 on (k=l) order 
by 1, 2, 3, 4;
 1      1       2       2
 1      1       3       3
 
-statement error
+query IIII
 select * from t1 join t2 on (i=j), t3 join t4 on (i+k=j+l)

Review Comment:
   It depends on order of rows returned by nodes:
   ```
   lass org.apache.ignite.IgniteException: Error at: 
(join_cross_product.test:38). sql: select * from t1 join t2 on (i=j), t3 join 
t4 on (i+k=j+l)
   
        at 
org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner$Query.execute(SqlScriptRunner.java:621)
        at 
org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner.run(SqlScriptRunner.java:146)
        at 
org.apache.ignite.internal.processors.query.calcite.logical.ScriptTestRunner$1.run(ScriptTestRunner.java:223)
        at java.base/java.lang.Thread.run(Thread.java:829)
   Caused by: java.lang.AssertionError: Not expected result at: 
(join_cross_product.test:38). [row=0, col=2, expected=2, actual=3]
   ```
   To make it correct you need to add
   `order by 1, 2, 3, 4`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to