timoninmaxim commented on code in PR #12142:
URL: https://github.com/apache/ignite/pull/12142#discussion_r2154685538
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java:
##########
@@ -1004,6 +989,19 @@ private <T> T applyOnNodeChannelWithFallback(UUID
tryNodeId, Function<ClientChan
return applyOnDefaultChannel(function, op, failures);
}
+ /**
+ * Returns the client channel that should be used to retry sending the
request.
+ */
+ private ClientChannel getRetryChannel(ClientChannelHolder hld,
ClientChannel ch)
+ throws ClientConnectionException, ClientAuthenticationException,
ClientProtocolError {
Review Comment:
all exceptions are runtime, then throws can be omitted.
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java:
##########
@@ -1004,6 +989,19 @@ private <T> T applyOnNodeChannelWithFallback(UUID
tryNodeId, Function<ClientChan
return applyOnDefaultChannel(function, op, failures);
}
+ /**
+ * Returns the client channel that should be used to retry sending the
request.
Review Comment:
Please, mention what is a difference with `onChannelFailure` method. AFAIU,
Latter must be called only after second attempt failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
