ptupitsyn commented on code in PR #6059:
URL: https://github.com/apache/ignite-3/pull/6059#discussion_r2158240399
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -612,14 +613,19 @@ private void write(ClientMessagePacker packer,
ChannelHandlerContext ctx) {
}
private void writeResponseHeader(
- ClientMessagePacker packer, long requestId, ChannelHandlerContext
ctx, boolean isNotification, boolean isError) {
+ ClientMessagePacker packer,
+ long requestId,
+ ChannelHandlerContext ctx,
+ boolean isNotification,
+ boolean isError,
+ long timestamp) {
packer.packLong(requestId);
writeFlags(packer, ctx, isNotification, isError);
// Include server timestamp in error and notification responses as
well:
// an operation can modify data and then throw an exception (e.g.
Compute task),
// so we still need to update client-side timestamp to preserve
causality guarantees.
- packer.packLong(clockService.currentLong());
+ packer.packLong(Math.max(clockService.currentLong(), timestamp));
Review Comment:
When job is executed by a remote node, `timestamp` can be greater than
`currentLong()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
