maksaska commented on code in PR #12128: URL: https://github.com/apache/ignite/pull/12128#discussion_r2160007398
########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java: ########## @@ -725,23 +737,22 @@ private <K, V> IgniteInternalFuture putAllAsync0( if (opCtx != null && opCtx.hasDataCenterId()) { assert drMap == null : drMap; - assert map != null || invokeMap != null; + assert keySet != null || invokeVals != null; dataCenterId = opCtx.dataCenterId(); } else dataCenterId = null; - final Map<?, EntryProcessor<K, V, Object>> invokeMap0 = (Map<K, EntryProcessor<K, V, Object>>)invokeMap; - if (log.isDebugEnabled()) - log.debug("Called putAllAsync(...) [tx=" + this + ", map=" + map + ", retval=" + retval + "]"); + log.debug("Called putAllAsync(...) [tx=" + this + + ", map=[" + keySet + ", " + vals + "], retval=" + retval + "]"); - assert map != null || invokeMap0 != null; + assert keySet != null || invokeVals != null; Review Comment: Done! ########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java: ########## @@ -725,23 +737,22 @@ private <K, V> IgniteInternalFuture putAllAsync0( if (opCtx != null && opCtx.hasDataCenterId()) { assert drMap == null : drMap; - assert map != null || invokeMap != null; + assert keySet != null || invokeVals != null; Review Comment: Done! ########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java: ########## @@ -725,23 +737,22 @@ private <K, V> IgniteInternalFuture putAllAsync0( if (opCtx != null && opCtx.hasDataCenterId()) { assert drMap == null : drMap; - assert map != null || invokeMap != null; + assert keySet != null || invokeVals != null; dataCenterId = opCtx.dataCenterId(); } else dataCenterId = null; - final Map<?, EntryProcessor<K, V, Object>> invokeMap0 = (Map<K, EntryProcessor<K, V, Object>>)invokeMap; - if (log.isDebugEnabled()) - log.debug("Called putAllAsync(...) [tx=" + this + ", map=" + map + ", retval=" + retval + "]"); + log.debug("Called putAllAsync(...) [tx=" + this + + ", map=[" + keySet + ", " + vals + "], retval=" + retval + "]"); - assert map != null || invokeMap0 != null; + assert keySet != null || invokeVals != null; final GridCacheReturn ret = new GridCacheReturn(localResult(), false); - if (F.isEmpty(map) && F.isEmpty(invokeMap0)) { + if (F.isEmpty(keySet) && vals == null && invokeVals != null) { Review Comment: Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org