sk0x50 commented on code in PR #6206:
URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2207322019
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java:
##########
@@ -135,7 +136,12 @@ public CompletableFuture<Void>
rollbackTimeoutExceededAsync() {
}
@Override
- public CompletableFuture<Void> finish(boolean commit, HybridTimestamp
executionTimestamp, boolean full, boolean timeoutExceeded) {
+ public CompletableFuture<Void> finish(
+ boolean commit,
+ @Nullable HybridTimestamp executionTimestamp,
Review Comment:
Fixed
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java:
##########
@@ -147,7 +147,7 @@ public CompletableFuture<Void> finish(boolean commit,
HybridTimestamp executionT
txFuture.complete(null);
- ((TxManagerImpl) txManager).completeReadOnlyTransactionFuture(new
TxIdAndTimestamp(readTimestamp, id()), timeoutExceeded);
+ ((TxManagerImpl) txManager).completeReadOnlyTransactionFuture(commit,
new TxIdAndTimestamp(readTimestamp, id()), timeoutExceeded);
Review Comment:
:ok_hand:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
