sergey-chugunov-1985 commented on code in PR #12188:
URL: https://github.com/apache/ignite/pull/12188#discussion_r2209960746
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java:
##########
@@ -18,11 +18,25 @@
package org.apache.ignite.internal.binary.streams;
import java.nio.ByteBuffer;
+import java.util.Iterator;
+import org.apache.ignite.internal.util.CommonUtils;
+import org.apache.ignite.internal.util.typedef.internal.A;
/**
* Utility class to provide static methods to create {@link BinaryInputStream}
or {@link BinaryOutputStream} in different modes.
*/
public class BinaryStreams {
+ /** Streams factory implementation. */
+ private static final BinaryStreamsFactory factory;
+
+ static {
+ Iterator<BinaryStreamsFactory> factories =
CommonUtils.loadService(BinaryStreamsFactory.class).iterator();
+
+ A.ensure(factories.hasNext(), "BinaryStreamsFactory implementation not
found. Please, add ignite-binary-impl to classpath");
Review Comment:
I suggest to be more specific in this error message and give a hint that we
tried and failed to load a service from classpath.
How about `Implementation for BinaryStreamsFactory service not found. Please
add ignite-binary-impl to classpath`.
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreamsFactory.java:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.binary.streams;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Utility class to provide static methods to create {@link BinaryInputStream}
or {@link BinaryOutputStream} in different modes.
Review Comment:
Javadoc is incorrect, it is not a utility class with a bunch of static
methods but an interface suitable for loading via ServiceLoader mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
