Phillippko commented on code in PR #6262:
URL: https://github.com/apache/ignite-3/pull/6262#discussion_r2212519273
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -393,11 +393,10 @@ protected void initChannel(Channel ch) {
result.complete(bindFut.channel());
} else if (bindFut.cause() instanceof BindException) {
- // TODO IGNITE-21614
result.completeExceptionally(
new IgniteException(
- PORT_IN_USE_ERR,
- "Cannot start thin client connector endpoint.
Port " + port + " is in use.",
+ BIND_ERR,
+ String.format("Cannot start thin client
connector endpoint at %s:%d.", addresses[0], port),
Review Comment:
Addresses could be empty. And let's use the format from the successful case
##########
modules/platforms/dotnet/Apache.Ignite/ErrorCodes.g.cs:
##########
@@ -462,6 +462,9 @@ public static class Network
/// <summary> AddressUnresolved error. </summary>
public const int AddressUnresolved = (GroupCode << 16) | (6 &
0xFFFF);
+
+ /// <summary> Bind error. </summary>
Review Comment:
```suggestion
/// <summary> BindException error. </summary>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
