vldpyatkov commented on code in PR #6300:
URL: https://github.com/apache/ignite-3/pull/6300#discussion_r2237109771
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManagerImpl.java:
##########
@@ -165,6 +165,7 @@ public void beforeNodeStop() {
@Override
public CompletableFuture<Void> stopAsync(ComponentContext
componentContext) {
enabledMetricExporters.clear();
+ log.warn("metric manager stopped", new Exception());
Review Comment:
It seems as a debug output.
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -158,7 +155,8 @@ public class LeaseUpdater {
LeaseTracker leaseTracker,
ClockService clockService,
AssignmentsTracker assignmentsTracker,
- ReplicationConfiguration replicationConfiguration
+ ReplicationConfiguration replicationConfiguration,
+ MetricManager metricManager
Review Comment:
How is the last parameter used?
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -172,6 +170,13 @@ public class LeaseUpdater {
this.topologyTracker = new TopologyTracker(topologyService);
this.updater = new Updater();
+ this.placementDriverMetrics = new PlacementDriverMetricSource(
+ updater::activeLeaseCount,
+ updater::leaseWithoutCandidatesCount,
+ () -> assignmentsTracker.stableAssignments().size(),
+ () -> assignmentsTracker.stableAssignments().size()
Review Comment:
Why is the stable assignment in both cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
