Re: [PR] IGNITE-26036 Add sorting in the list of metrics for cli by name [ignite-3]

[via GitHub]

ivanzlenko commented on code in PR #6332:
URL: https://github.com/apache/ignite-3/pull/6332#discussion_r2239060612


##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/metric/ItClusterMetricCommandTest.java:
##########
@@ -79,15 +82,29 @@ void metricList() {
         execute("cluster", "metric", "source", "list", "--plain", "--url", 
NODE_URL);
 
         // Then
-        List<Executable> assertions = new ArrayList<>();
+        List<String> sourceNames = Arrays.stream(ALL_METRIC_SOURCES)
+                
.map(org.apache.ignite.rest.client.model.MetricSource::getName).sorted()

Review Comment:
   ```suggestion
                   
.map(org.apache.ignite.rest.client.model.MetricSource::getName)
                   .sorted()
   ```



##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/CliIntegrationTest.java:
##########
@@ -104,7 +104,7 @@ public abstract class CliIntegrationTest extends 
ClusterPerClassIntegrationTest
 
     private CommandLine cmd;
 
-    private StringWriter sout;
+    public StringWriter sout;

Review Comment:
   Looks like an error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org