tkalkirill commented on code in PR #6329:
URL: https://github.com/apache/ignite-3/pull/6329#discussion_r2239681678
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableUtils.java:
##########
@@ -82,38 +81,28 @@ public static List<Integer>
indexIdsAtRwTxBeginTs(CatalogService catalogService,
}
/**
- * Collects a list of tables that were removed from the catalog and should
have been dropped due to a low watermark (if the catalog
- * version in which the table was removed is less than or equal to the
active catalog version of the low watermark).
+ * Collects all IDs of tables that were not dropped or were dropped, but
should not have been destroyed yet due to a low watermark
+ * (if the catalog version in which the table was removed were less than
or equal to the active catalog version of the low watermark).
*
* @param catalogService Catalog service.
* @param lowWatermark Low watermark, {@code null} if it has never been
updated.
*/
- static List<DroppedTableInfo> droppedTables(CatalogService catalogService,
@Nullable HybridTimestamp lowWatermark) {
- if (lowWatermark == null) {
- return List.of();
+ static Set<Integer> aliveTables(CatalogService catalogService, @Nullable
HybridTimestamp lowWatermark) {
Review Comment:
Let's mention this in the method description, that it should be called
strictly before the watch deployment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
