timoninmaxim commented on code in PR #317:
URL: https://github.com/apache/ignite-extensions/pull/317#discussion_r2269518045
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java:
##########
@@ -0,0 +1,221 @@
+package org.apache.ignite.cdc.postgresql;
+
+import java.math.BigDecimal;
+import java.sql.PreparedStatement;
+import java.sql.Types;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.UUID;
+import org.apache.ignite.IgniteException;
+
+import static
org.apache.ignite.cdc.postgresql.JavaToSqlTypeMapper.JavaToSqlType.OBJECT;
+
+/** */
+class JavaToSqlTypeMapper {
+ /** */
+ private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new
HashMap<>();
+
+ static {
+ for (JavaToSqlType type : JavaToSqlType.values())
+ JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type);
+ }
+
+ /**
+ * Sets a value in the PreparedStatement at the given index using the
appropriate setter
+ * based on the runtime type of the object.
+ * @param stmt {@link PreparedStatement}
+ * @param idx value index in {@link PreparedStatement}
+ * @param obj value
+ */
+ public void setValue(PreparedStatement stmt, int idx, Object obj) {
+ try {
+ if (obj == null) {
+ stmt.setNull(idx, Types.NULL);
+
+ return;
+ }
+
+ if (obj instanceof byte[]) {
+ stmt.setBytes(idx, (byte[])obj); // Preferred setter for byte[]
+
+ return;
+ }
+
+ JavaToSqlType type =
JAVA_TO_SQL_TYPE_MAP.getOrDefault(obj.getClass().getName(), OBJECT);
+
+ if (type != null)
+ stmt.setObject(idx, obj, type.typeId());
+ else
+ stmt.setObject(idx, obj);
+ }
+ catch (Throwable e) {
+ throw new IgniteException("Failed to set value for type!", e);
+ }
+ }
+
+ /**
+ * Renders the SQL type declaration for a given Java class name based on
its mapping,
+ * optionally including precision and scale if the SQL type supports them.
+ *
+ * @param clsName the fully qualified Java class name used to look up the
corresponding SQL type
+ * @param precision optional precision value to include in the SQL type,
if supported
+ * @param scale optional scale value to include in the SQL type, if
supported
+ * @return the SQL type string with appropriate precision and scale
formatting
+ */
+ public String renderSqlType(String clsName, Integer precision, Integer
scale) {
+ JavaToSqlType type = JAVA_TO_SQL_TYPE_MAP.getOrDefault(clsName,
OBJECT);
+
+ if (type.precision()) {
+ if (type.scale()) {
+ if (precision != null && scale != null)
+ return type.sqlType().replace("?", String.format("(%d,
%d)", precision, scale));
+
+ if (precision != null)
+ return type.sqlType().replace("?", String.format("(%d)",
precision));
+
+ return type.sqlType().replace("?", "");
+ }
+
+ if (precision != null)
+ return type.sqlType().replace("?", String.format("(%d)",
precision));
+
+ return type.sqlType().replace("?", "");
+ }
+
+ return type.sqlType();
+ }
+
+ /** */
+ enum JavaToSqlType {
+ /** */
+ STRING(String.class, "VARCHAR?", true, false, Types.VARCHAR),
+
+ /** */
+ INTEGER(Integer.class, "INT", false, false, Types.INTEGER),
+
+ /** */
+ LONG(Long.class, "BIGINT", false, false, Types.BIGINT),
+
+ /** */
+ BOOLEAN(Boolean.class, "BOOL", false, false, Types.BOOLEAN),
+
+ /** */
+ DOUBLE(Double.class, "NUMERIC?", true, true, Types.DOUBLE),
+
+ /** */
+ FLOAT(Float.class, "NUMERIC?", true, true, Types.FLOAT),
+
+ /** */
+ BIG_DECIMAL(BigDecimal.class, "NUMERIC?", true, true, Types.DECIMAL),
+
+ /** */
+ SHORT(Short.class, "SMALLINT", false, false, Types.SMALLINT),
+
+ /** */
+ BYTE(Byte.class, "SMALLINT", false, false, Types.SMALLINT),
+
+ /** */
+ SQL_DATE(java.sql.Date.class, "DATE", false, false, Types.DATE),
+
+ /** */
+ SQL_TIME(java.sql.Time.class, "TIME?", true, false, Types.TIME),
+
+ /** */
+ SQL_TIMESTAMP(java.sql.Timestamp.class, "TIMESTAMP?", true, false,
Types.TIMESTAMP),
+
+ /** */
+ UTIL_DATE(java.util.Date.class, "TIMESTAMP?", true, false,
Types.TIMESTAMP),
+
+ /** */
+ UUID_TYPE(UUID.class, "UUID", false, false, Types.OTHER),
+
+ /** */
+ LOCAL_DATE(LocalDate.class, "DATE", false, false, Types.DATE),
+
+ /** */
+ LOCAL_TIME(LocalTime.class, "TIME?", true, false, Types.TIME),
+
+ /** */
+ LOCAL_DATE_TIME(LocalDateTime.class, "TIMESTAMP?", true, false,
Types.TIMESTAMP),
+
+ /** */
+ OFFSET_TIME(OffsetTime.class, "VARCHAR?", true, false, Types.VARCHAR),
+
+ /** */
+ OFFSET_DATE_TIME(OffsetDateTime.class, "TIMESTAMP WITH TIME ZONE",
false, false,
+ Types.TIMESTAMP_WITH_TIMEZONE),
+
+ /** */
+ BYTE_ARRAY(byte[].class, "BYTEA", false, false, Types.OTHER),
+
+ /** */
+ OBJECT(Object.class, "OTHER", false, false, Types.OTHER);
+
+ /** */
+ private final String javaTypeName;
+
+ /** */
+ private final String sqlType;
+
+ /** */
+ private final boolean precision;
+
+ /** */
+ private final boolean scale;
+
+ /** */
+ private final int typeId;
+
+ /**
+ * @param javaTypeName Java type name.
+ * @param sqlType Sql type.
+ * @param precision Has precision.
+ * @param scale Has scale.
+ * @param typeId {@link Types}
+ */
+ JavaToSqlType(
+ Class<?> javaTypeName,
Review Comment:
not a name
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java:
##########
@@ -0,0 +1,221 @@
+package org.apache.ignite.cdc.postgresql;
+
+import java.math.BigDecimal;
+import java.sql.PreparedStatement;
+import java.sql.Types;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.UUID;
+import org.apache.ignite.IgniteException;
+
+import static
org.apache.ignite.cdc.postgresql.JavaToSqlTypeMapper.JavaToSqlType.OBJECT;
+
+/** */
+class JavaToSqlTypeMapper {
+ /** */
+ private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new
HashMap<>();
+
+ static {
+ for (JavaToSqlType type : JavaToSqlType.values())
+ JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type);
+ }
+
+ /**
+ * Sets a value in the PreparedStatement at the given index using the
appropriate setter
+ * based on the runtime type of the object.
+ * @param stmt {@link PreparedStatement}
+ * @param idx value index in {@link PreparedStatement}
+ * @param obj value
+ */
+ public void setValue(PreparedStatement stmt, int idx, Object obj) {
+ try {
+ if (obj == null) {
+ stmt.setNull(idx, Types.NULL);
+
+ return;
+ }
+
+ if (obj instanceof byte[]) {
+ stmt.setBytes(idx, (byte[])obj); // Preferred setter for byte[]
+
+ return;
+ }
+
+ JavaToSqlType type =
JAVA_TO_SQL_TYPE_MAP.getOrDefault(obj.getClass().getName(), OBJECT);
+
+ if (type != null)
+ stmt.setObject(idx, obj, type.typeId());
+ else
+ stmt.setObject(idx, obj);
+ }
+ catch (Throwable e) {
+ throw new IgniteException("Failed to set value for type!", e);
Review Comment:
Add `stmt` and `idx` to the error message
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java:
##########
@@ -0,0 +1,221 @@
+package org.apache.ignite.cdc.postgresql;
+
+import java.math.BigDecimal;
+import java.sql.PreparedStatement;
+import java.sql.Types;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.UUID;
+import org.apache.ignite.IgniteException;
+
+import static
org.apache.ignite.cdc.postgresql.JavaToSqlTypeMapper.JavaToSqlType.OBJECT;
+
+/** */
+class JavaToSqlTypeMapper {
+ /** */
+ private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new
HashMap<>();
+
+ static {
+ for (JavaToSqlType type : JavaToSqlType.values())
+ JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type);
+ }
+
+ /**
+ * Sets a value in the PreparedStatement at the given index using the
appropriate setter
+ * based on the runtime type of the object.
+ * @param stmt {@link PreparedStatement}
+ * @param idx value index in {@link PreparedStatement}
+ * @param obj value
+ */
+ public void setValue(PreparedStatement stmt, int idx, Object obj) {
+ try {
+ if (obj == null) {
+ stmt.setNull(idx, Types.NULL);
+
+ return;
+ }
+
+ if (obj instanceof byte[]) {
+ stmt.setBytes(idx, (byte[])obj); // Preferred setter for byte[]
+
+ return;
+ }
+
+ JavaToSqlType type =
JAVA_TO_SQL_TYPE_MAP.getOrDefault(obj.getClass().getName(), OBJECT);
+
+ if (type != null)
+ stmt.setObject(idx, obj, type.typeId());
+ else
+ stmt.setObject(idx, obj);
Review Comment:
Not covered with test
##########
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapperTest.java:
##########
@@ -0,0 +1,438 @@
+package org.apache.ignite.cdc.postgresql;
Review Comment:
license
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java:
##########
@@ -0,0 +1,221 @@
+package org.apache.ignite.cdc.postgresql;
Review Comment:
License
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java:
##########
@@ -0,0 +1,221 @@
+package org.apache.ignite.cdc.postgresql;
+
+import java.math.BigDecimal;
+import java.sql.PreparedStatement;
+import java.sql.Types;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.UUID;
+import org.apache.ignite.IgniteException;
+
+import static
org.apache.ignite.cdc.postgresql.JavaToSqlTypeMapper.JavaToSqlType.OBJECT;
+
+/** */
+class JavaToSqlTypeMapper {
+ /** */
+ private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new
HashMap<>();
+
+ static {
+ for (JavaToSqlType type : JavaToSqlType.values())
+ JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type);
+ }
+
+ /**
+ * Sets a value in the PreparedStatement at the given index using the
appropriate setter
+ * based on the runtime type of the object.
+ * @param stmt {@link PreparedStatement}
+ * @param idx value index in {@link PreparedStatement}
+ * @param obj value
+ */
+ public void setValue(PreparedStatement stmt, int idx, Object obj) {
+ try {
+ if (obj == null) {
+ stmt.setNull(idx, Types.NULL);
+
+ return;
+ }
+
+ if (obj instanceof byte[]) {
+ stmt.setBytes(idx, (byte[])obj); // Preferred setter for byte[]
+
+ return;
+ }
+
+ JavaToSqlType type =
JAVA_TO_SQL_TYPE_MAP.getOrDefault(obj.getClass().getName(), OBJECT);
+
+ if (type != null)
+ stmt.setObject(idx, obj, type.typeId());
+ else
+ stmt.setObject(idx, obj);
+ }
+ catch (Throwable e) {
+ throw new IgniteException("Failed to set value for type!", e);
+ }
+ }
+
+ /**
+ * Renders the SQL type declaration for a given Java class name based on
its mapping,
+ * optionally including precision and scale if the SQL type supports them.
+ *
+ * @param clsName the fully qualified Java class name used to look up the
corresponding SQL type
+ * @param precision optional precision value to include in the SQL type,
if supported
+ * @param scale optional scale value to include in the SQL type, if
supported
+ * @return the SQL type string with appropriate precision and scale
formatting
+ */
+ public String renderSqlType(String clsName, Integer precision, Integer
scale) {
+ JavaToSqlType type = JAVA_TO_SQL_TYPE_MAP.getOrDefault(clsName,
OBJECT);
+
+ if (type.precision()) {
+ if (type.scale()) {
+ if (precision != null && scale != null)
+ return type.sqlType().replace("?", String.format("(%d,
%d)", precision, scale));
Review Comment:
why do you need replace? let's append precision, scale to type name
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java:
##########
@@ -0,0 +1,221 @@
+package org.apache.ignite.cdc.postgresql;
+
+import java.math.BigDecimal;
+import java.sql.PreparedStatement;
+import java.sql.Types;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.UUID;
+import org.apache.ignite.IgniteException;
+
+import static
org.apache.ignite.cdc.postgresql.JavaToSqlTypeMapper.JavaToSqlType.OBJECT;
+
+/** */
+class JavaToSqlTypeMapper {
+ /** */
+ private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new
HashMap<>();
+
+ static {
+ for (JavaToSqlType type : JavaToSqlType.values())
+ JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type);
+ }
+
+ /**
+ * Sets a value in the PreparedStatement at the given index using the
appropriate setter
+ * based on the runtime type of the object.
+ * @param stmt {@link PreparedStatement}
+ * @param idx value index in {@link PreparedStatement}
+ * @param obj value
+ */
+ public void setValue(PreparedStatement stmt, int idx, Object obj) {
+ try {
+ if (obj == null) {
+ stmt.setNull(idx, Types.NULL);
Review Comment:
not covered with test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
