timoninmaxim commented on code in PR #12221:
URL: https://github.com/apache/ignite/pull/12221#discussion_r2272398693


##########
modules/core/src/test/java/org/apache/ignite/internal/metric/MetricsConfigurationTest.java:
##########
@@ -400,8 +400,8 @@ public void 
checkOnStartAndRestart(IgniteBiInClosureX<IgniteEx, IgniteEx> afterS
 
             afterStart.apply(g0, g1);
 
-            g0.close();
-            g1.close();

Review Comment:
   AFAIU, the problem is that DMS doesn't write the metrics on disk until a 
node stopped, and `cancel = false` enforces a node to wait finishing the 
writing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to