lowka commented on code in PR #6374:
URL: https://github.com/apache/ignite-3/pull/6374#discussion_r2272424047
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappedFragment.java:
##########
@@ -131,12 +131,32 @@ public Long2ObjectMap<ColocationGroup> groupsBySourceId()
{
public MappedFragment
replaceColocationGroups(Long2ObjectMap<ColocationGroup> replacedGroups) {
List<ColocationGroup> newGroups = new
ArrayList<>(groupsBySourceId.size());
+ // Because a colocation group may contain multiple sources, partition
pruning (PP) splits a colocation group in multiple groups.
+ // Each source id affected by PP goes into a separate group.
+ //
+ // Consider the following scenario:
+ // ColocationGroup [ sourceIds = [0, 1], ... ] where sourceIds point
to the same table but the one with sourceId=0
+ // has a predicate and the one with source=2 does not. In this case we
need to create two colocation groups:
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
