Copilot commented on code in PR #6421:
URL: https://github.com/apache/ignite-3/pull/6421#discussion_r2277144109


##########
migration-tools/packaging/cli/start.bat:
##########
@@ -22,14 +22,13 @@ if "%OS%"=="Windows_NT" setlocal
 
 set DIRNAME=%~dp0
 if "%DIRNAME%"=="" set DIRNAME=.
-set LIB_DIR="@LIB_DIR@"
 
 @rem Resolve any "." and ".." in LIB_DIR to make it shorter.
-for %%i in ("%LIB_DIR%") do set LIB_DIR=%%~fi
+for %%i in ("@LIB_DIR@") do set LIB_DIR=%%~fi

Review Comment:
   The LIB_DIR variable is now being resolved directly from the @LIB_DIR@ 
placeholder without being assigned to a variable first. This could cause issues 
if @LIB_DIR@ contains special characters or spaces that weren't handled by the 
removed assignment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to