sk0x50 commented on code in PR #6416: URL: https://github.com/apache/ignite-3/pull/6416#discussion_r2281873207
########## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/ZoneMetricSource.java: ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.distributionzones; + +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.pendingPartAssignmentsQueueKey; +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.stablePartAssignmentsKey; + +import java.util.List; +import org.apache.ignite.internal.catalog.descriptors.CatalogZoneDescriptor; +import org.apache.ignite.internal.metastorage.Entry; +import org.apache.ignite.internal.metastorage.MetaStorageManager; +import org.apache.ignite.internal.metrics.AbstractMetricSource; +import org.apache.ignite.internal.metrics.IntGauge; +import org.apache.ignite.internal.metrics.Metric; +import org.apache.ignite.internal.partitiondistribution.Assignment; +import org.apache.ignite.internal.partitiondistribution.Assignments; +import org.apache.ignite.internal.partitiondistribution.AssignmentsQueue; +import org.apache.ignite.internal.replicator.ZonePartitionId; + +/** + * Distribution metric source for a specific zone. + */ +public class ZoneMetricSource extends AbstractMetricSource<ZoneMetricSource.Holder> { + /** Source name. */ + public static final String SOURCE_NAME = "zones"; + + /** Metric names. */ + public static final String LOCAL_UNREBALANCED_PARTITIONS_COUNT = "LocalUnrebalancedPartitionsCount"; + public static final String TOTAL_UNREBALANCED_PARTITIONS_COUNT = "TotalUnrebalancedPartitionsCount"; + + /** Meta Storage manager. */ + private final MetaStorageManager metaStorageManager; + + /** Node name, aka consistent identifier. */ + private final String nodeName; + + /** Zone descriptor. */ + public final CatalogZoneDescriptor zoneDescriptor; + + /** + * Creates a new zone metric source for a specific zone. + * + * @param metaStorageManager Meta Storage manager. + * @param consistentId Name of the node. + * @param zoneDescriptor Zone descriptor. + */ + public ZoneMetricSource(MetaStorageManager metaStorageManager, String consistentId, CatalogZoneDescriptor zoneDescriptor) { + super(SOURCE_NAME + '.' + zoneDescriptor.name(), "Distribution zone metrics.", "zones"); + + this.nodeName = consistentId; + this.zoneDescriptor = zoneDescriptor; + this.metaStorageManager = metaStorageManager; + } + + @Override + protected Holder createHolder() { + return new Holder(this); + } + + /** Holder. */ + protected static class Holder implements AbstractMetricSource.Holder<Holder> { + /** List of actual metrics. */ + private final List<Metric> metrics; + + Holder(ZoneMetricSource source) { + var localUnrebalancedPartitionsCount = new IntGauge( + LOCAL_UNREBALANCED_PARTITIONS_COUNT, + "The number of partitions that should be moved to this node.", + () -> { + int unrebalancedParts = 0; + + for (int i = 0; i < source.zoneDescriptor.partitions(); ++i) { + ZonePartitionId zonePartitionId = new ZonePartitionId(source.zoneDescriptor.id(), i); + + Entry pendingEntry = source.metaStorageManager.getLocally(pendingPartAssignmentsQueueKey(zonePartitionId)); + AssignmentsQueue pendingAssignmentsQueue = AssignmentsQueue.fromBytes(pendingEntry.value()); + + if (pendingAssignmentsQueue != null) { + Entry stableEntry = source.metaStorageManager.getLocally(stablePartAssignmentsKey(zonePartitionId)); + + Assignments stableAssignments = stableEntry.value() == null + ? Assignments.EMPTY + : Assignments.fromBytes(stableEntry.value()); + Assignments targetAssignments = pendingAssignmentsQueue.peekLast(); + + boolean stable = presentInAssignments(stableAssignments, source.nodeName); + boolean pending = presentInAssignments(targetAssignments, source.nodeName); + + if (!stable && pending) { + unrebalancedParts += 1; Review Comment: IMHO, there is no difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
