sanpwc commented on code in PR #6408:
URL: https://github.com/apache/ignite-3/pull/6408#discussion_r2283040422
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -957,18 +960,39 @@ private void onLogicalTopologyChanged(long term) {
// If the future is not here yet, this means we are still starting, so
learners will be updated after start
// (if we happen to become a leader).
+ if (serviceFuture == null) {
+ return;
+ }
- if (serviceFuture != null) {
- serviceFuture.thenCompose(service ->
service.isCurrentNodeLeader().thenCompose(isLeader -> {
- if (!isLeader) {
- return nullCompletedFuture();
- }
-
- return service.updateLearners(term);
Review Comment:
Is `service.updateLearners(term);` still called within onElectedAsLeader?
If true how it's linearized with `service.updateLearners(term);` calls in
onLogicalTopologyChanged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
