Phillippko commented on code in PR #6343:
URL: https://github.com/apache/ignite-3/pull/6343#discussion_r2284583565
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -610,9 +610,20 @@ private void fsyncDeltaFile(
currentCheckpointProgress.blockPartitionDestruction(partitionId);
try {
- fsyncDeltaFilePageStoreOnCheckpointThread(filePageStore,
pagesWritten);
+ fsyncDeltaFilePageStoreOnCheckpointThread(filePageStore);
+
+ blockingSectionBegin();
+ try {
+ filePageStore.sync();
+ } finally {
+ blockingSectionEnd();
+ }
Review Comment:
Pages are fully synced only after both delta and main file are synced, so I
moved addAndGet outside
Same about updating checkpointedPages - imho it is valid to do only after
delta file is renamed and checkpoint can't fail
Moved blockingSection / sync to a new method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
