denis-chudov commented on code in PR #6413:
URL: https://github.com/apache/ignite-3/pull/6413#discussion_r2287758640
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/configuration/TransactionConfigurationSchema.java:
##########
@@ -39,7 +41,7 @@ public class TransactionConfigurationSchema {
@Range(min = 1)
@Value(hasDefault = true)
@PublicName(legacyNames = "readWriteTimeout")
- public final long readWriteTimeoutMillis = TimeUnit.SECONDS.toMillis(30);
+ public final long readWriteTimeoutMillis =
TimeUnit.SECONDS.toMillis(DEFAULT_RW_TX_TIMEOUT_SECONDS);
Review Comment:
IgniteTransactions (and RunInTransactionInternalImpl, because logic stays
common for clients and embedded mode) are located in ignite-api module, and
TransactionConfiguration is not available there. But I want to have a single
source of this number (default rw txn timeout). This is the reason why I
created a separate constant, which is used as default timeout in both places:
in `runInTransaction` and in TransactionConfiguration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
