sergey-chugunov-1985 commented on code in PR #12204:
URL: https://github.com/apache/ignite/pull/12204#discussion_r2300195314
##########
modules/codegen2/src/main/java/org/apache/ignite/internal/MessageSerializerGenerator.java:
##########
@@ -464,6 +478,19 @@ else if (sameType(type,
"org.apache.ignite.lang.IgniteUuid"))
else if (sameType(type,
"org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion"))
returnFalseIfReadFailed(name,
"reader.readAffinityTopologyVersion");
+ else if (assignableFrom(erasedType(type),
type(Map.class.getName()))) {
+ List<? extends TypeMirror> typeArgs =
((DeclaredType)type).getTypeArguments();
+
+ assert typeArgs.size() == 2;
+
+ boolean linked = sameErasedType(type, LinkedHashMap.class);
Review Comment:
Currently there is no LinkedHashMap among all communication messages, so
this support looks redundant. Please remove this code and always use `false`
for this parameter.
Please also create a ticket to make `MessageReader#readMap` deprecated and
add a TODO here mentioning this ticket to switch to a new `readMap` method
without the flag parameter.
Also please delete a test for LinkedHashMap as we don't have plans yet to
use this functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
