sergey-chugunov-1985 commented on code in PR #12287:
URL: https://github.com/apache/ignite/pull/12287#discussion_r2303402242
##########
modules/core/src/test/java/org/apache/ignite/internal/IgniteClientReconnectApiExceptionTest.java:
##########
@@ -764,7 +764,7 @@ private void doTestIgniteOperationOnDisconnect(Ignite
client, final List<T2<Call
throws Exception {
assertNotNull(client.cache(DEFAULT_CACHE_NAME));
- final IgniteDiscoverySpi clientSpi = spi0(client);
+ final TestTcpDiscoverySpi clientSpi =
(TestTcpDiscoverySpi)spi0(client);
Review Comment:
Casting to IgniteDiscoverySpiInternalListenerSupport should be enough here
as well I guess.
##########
modules/core/src/test/java/org/apache/ignite/internal/IgniteClientReconnectStopTest.java:
##########
@@ -56,7 +56,7 @@ public void testStopWhenDisconnected() throws Exception {
final CountDownLatch disconnectLatch = new CountDownLatch(1);
final CountDownLatch reconnectLatch = new CountDownLatch(1);
- final IgniteDiscoverySpi clientSpi = spi0(client);
+ final TestTcpDiscoverySpi clientSpi =
(TestTcpDiscoverySpi)spi0(client);
Review Comment:
The same is here.
##########
modules/core/src/test/java/org/apache/ignite/messaging/GridMessagingSelfTest.java:
##########
@@ -1141,7 +1141,7 @@ public void testAsyncOld() throws Exception {
public void testAsync() throws Exception {
final AtomicInteger msgCnt = new AtomicInteger();
- IgniteDiscoverySpi discoSpi =
(IgniteDiscoverySpi)ignite2.configuration().getDiscoverySpi();
+ TestTcpDiscoverySpi discoSpi =
(TestTcpDiscoverySpi)ignite2.configuration().getDiscoverySpi();
Review Comment:
The same is here.
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/IgniteWalRecoveryTest.java:
##########
@@ -597,7 +597,7 @@ public void
testBinaryRecoverBeforePMEWhenMiddleCheckpoint() throws Exception {
final IgniteConfiguration onJoinCfg =
optimize(getConfiguration(ig2Name));
// Check restore beeing called before PME and joining node to cluster.
- ((IgniteDiscoverySpi)onJoinCfg.getDiscoverySpi())
+ ((TestTcpDiscoverySpi)onJoinCfg.getDiscoverySpi())
Review Comment:
The same is here.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CacheLateAffinityAssignmentTest.java:
##########
@@ -1397,7 +1397,7 @@ public void
testDelayAssignmentAffinityChangedUnexpectedPME() throws Exception {
DiscoverySpiTestListener lsnr = new DiscoverySpiTestListener();
-
((IgniteDiscoverySpi)ignite0.configuration().getDiscoverySpi()).setInternalListener(lsnr);
+
((TestTcpDiscoverySpi)ignite0.configuration().getDiscoverySpi()).setInternalListener(lsnr);
Review Comment:
It is enough to cast to `IgniteDiscoverySpiInternalListenerSupport` as it is
done in some other tests below.
##########
modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/ZookeeperDiscoverySpi.java:
##########
@@ -524,6 +504,14 @@ public Map<String, Object> getLocNodeAttrs() {
return locNodeAttrs;
}
+ /**
+ * Callback before join topology.
+ * @param locNode Local node.
+ */
+ public void beforeJoinTopology(ClusterNode locNode) {
Review Comment:
Do you think it is a good idea to specify in a javadoc that this method is
intended for testing purposes only?
##########
modules/core/src/test/java/org/apache/ignite/messaging/GridMessagingSelfTest.java:
##########
@@ -1028,7 +1028,7 @@ public void testNullMessages() throws Exception {
public void testAsyncOld() throws Exception {
final AtomicInteger msgCnt = new AtomicInteger();
- IgniteDiscoverySpi discoSpi =
(IgniteDiscoverySpi)ignite2.configuration().getDiscoverySpi();
+ TestTcpDiscoverySpi discoSpi =
(TestTcpDiscoverySpi)ignite2.configuration().getDiscoverySpi();
Review Comment:
The same is here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
