alievmirza commented on code in PR #6493: URL: https://github.com/apache/ignite-3/pull/6493#discussion_r2304356430
########## modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/recovery/ItDisasterRecoveryControllerRestartPartitionsWithCleanupTest.java: ########## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.rest.recovery; + +import static java.util.stream.Collectors.toSet; +import static org.apache.ignite.internal.TestDefaultProfilesNames.DEFAULT_AIPERSIST_PROFILE_NAME; +import static org.apache.ignite.internal.lang.IgniteSystemProperties.colocationEnabled; +import static org.apache.ignite.internal.rest.constants.HttpCode.BAD_REQUEST; +import static org.apache.ignite.internal.rest.constants.HttpCode.OK; +import static org.apache.ignite.lang.util.IgniteNameUtils.canonicalName; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.containsString; +import static org.hamcrest.Matchers.equalTo; +import static org.hamcrest.Matchers.is; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import io.micronaut.http.HttpRequest; +import io.micronaut.http.HttpResponse; +import io.micronaut.http.HttpStatus; +import io.micronaut.http.MutableHttpRequest; +import io.micronaut.http.client.HttpClient; +import io.micronaut.http.client.annotation.Client; +import io.micronaut.http.client.exceptions.HttpClientResponseException; +import io.micronaut.test.extensions.junit5.annotation.MicronautTest; +import jakarta.inject.Inject; +import java.util.Collection; +import java.util.Set; +import org.apache.ignite.Ignite; +import org.apache.ignite.internal.ClusterConfiguration; +import org.apache.ignite.internal.ClusterPerClassIntegrationTest; +import org.apache.ignite.internal.rest.api.recovery.RestartPartitionsRequest; +import org.apache.ignite.internal.rest.api.recovery.RestartZonePartitionsRequest; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.condition.DisabledIf; + +/** Test for disaster recovery restart partitions with cleanup command. */ +@MicronautTest +public class ItDisasterRecoveryControllerRestartPartitionsWithCleanupTest extends ClusterPerClassIntegrationTest { + private static final String NODE_URL = "http://localhost:"; + ClusterConfiguration.DEFAULT_BASE_HTTP_PORT; + + private static final String FIRST_ZONE = "first_ZONE"; + + private static final String TABLE_NAME = "first_ZONE_table"; + + private static final String QUALIFIED_TABLE_NAME = canonicalName("PUBLIC", TABLE_NAME); + + public static final String RESTART_PARTITIONS_WITH_CLEANUP_ENDPOINT = "/partitions/restartWithCleanup"; + + public static final String RESTART_ZONE_PARTITIONS_WITH_CLEANUP_ENDPOINT = "zone/partitions/restartWithCleanup"; + + @Inject + @Client(NODE_URL + "/management/v1/recovery/") + HttpClient client; + + @BeforeAll + public void setUp() { + sql(String.format("CREATE ZONE \"%s\" storage profiles ['%s']", FIRST_ZONE, DEFAULT_AIPERSIST_PROFILE_NAME)); + sql(String.format("CREATE TABLE PUBLIC.\"%s\" (id INT PRIMARY KEY, val INT) ZONE \"%s\"", TABLE_NAME, + FIRST_ZONE)); + } + + @Test + public void testRestartPartitionWithCleanupZoneNotFound() { + String unknownZone = "unknown_zone"; + + MutableHttpRequest<?> post = restartPartitionsRequest(Set.of(), unknownZone, QUALIFIED_TABLE_NAME, Set.of()); + + HttpClientResponseException e = assertThrows(HttpClientResponseException.class, + () -> client.toBlocking().exchange(post)); + + assertThat(e.getResponse().code(), is(BAD_REQUEST.code())); + + assertThat(e.getMessage(), containsString("Distribution zone was not found [zoneName=" + unknownZone + "]")); + } + + @Test + // TODO: remove this test when colocation is enabled https://issues.apache.org/jira/browse/IGNITE-22522 + @DisabledIf("org.apache.ignite.internal.lang.IgniteSystemProperties#colocationEnabled") + public void testRestartPartitionWithCleanupTableNotFound() { + String tableName = "PUBLIC.unknown_table"; + + MutableHttpRequest<?> post = restartPartitionsRequest(Set.of(), FIRST_ZONE, tableName, Set.of()); + + HttpClientResponseException e = assertThrows(HttpClientResponseException.class, + () -> client.toBlocking().exchange(post)); + + assertThat(e.getResponse().code(), is(BAD_REQUEST.code())); + assertThat(e.getMessage(), containsString("The table does not exist [name=" + tableName.toUpperCase() + "]")); + } + + @Test + void testRestartPartitionsWithCleanupIllegalPartitionNegative() { + MutableHttpRequest<?> post = restartPartitionsRequest(Set.of(), FIRST_ZONE, QUALIFIED_TABLE_NAME, Set.of(0, 5, -1, -10)); + + HttpClientResponseException e = assertThrows(HttpClientResponseException.class, + () -> client.toBlocking().exchange(post)); + + assertThat(e.getResponse().code(), is(BAD_REQUEST.code())); + + assertThat(e.getMessage(), containsString("Partition ID can't be negative, found: -10")); + } + + @Test + void testRestartPartitionsWithCleanupPartitionsOutOfRange() { + MutableHttpRequest<?> post = restartPartitionsRequest(Set.of(), FIRST_ZONE, QUALIFIED_TABLE_NAME, Set.of(DEFAULT_PARTITION_COUNT)); + + HttpClientResponseException e = assertThrows(HttpClientResponseException.class, + () -> client.toBlocking().exchange(post)); + + assertThat(e.getResponse().code(), is(BAD_REQUEST.code())); + assertThat(e.getMessage(), containsString( + String.format( + "Partition IDs should be in range [0, %d] for zone %s, found: %d", + DEFAULT_PARTITION_COUNT - 1, + FIRST_ZONE, + DEFAULT_PARTITION_COUNT + ) + )); + } + + @Test + void testRestartPartitionsWithCleanupNodesAreCaseSensitive() { + Set<String> uppercaseNodeNames = nodeNames(initialNodes() - 1).stream() + .map(String::toUpperCase) + .collect(toSet()); + + MutableHttpRequest<?> post = restartPartitionsRequest(uppercaseNodeNames, FIRST_ZONE, QUALIFIED_TABLE_NAME, Set.of()); + + HttpClientResponseException e = assertThrows(HttpClientResponseException.class, + () -> client.toBlocking().exchange(post)); + + assertThat(e.getStatus(), equalTo(HttpStatus.BAD_REQUEST)); + uppercaseNodeNames.forEach(nodeName -> assertThat(e.getMessage(), containsString(nodeName))); + } + + @Test + public void testRestartAllPartitionsWithCleanup() { + MutableHttpRequest<?> post = restartPartitionsRequest(Set.of(), FIRST_ZONE, QUALIFIED_TABLE_NAME, Set.of()); + + HttpResponse<Void> response = client.toBlocking().exchange(post); + + assertThat(response.getStatus().getCode(), is(OK.code())); + } + + @Test + public void testRestartSpecifiedPartitionsWithCleanup() { + MutableHttpRequest<?> post = restartPartitionsRequest(Set.of(), FIRST_ZONE, QUALIFIED_TABLE_NAME, Set.of(0, 1)); + + HttpResponse<Void> response = client.toBlocking().exchange(post); + + assertThat(response.getStatus().getCode(), is(OK.code())); + } + + @Test + public void testRestartPartitionsWithCleanupByNodes() { + Set<String> nodeNames = nodeNames(initialNodes() - 1); + + MutableHttpRequest<?> post = restartPartitionsRequest(nodeNames, FIRST_ZONE, QUALIFIED_TABLE_NAME, Set.of()); + + HttpResponse<Void> response = client.toBlocking().exchange(post); + + assertThat(response.getStatus().getCode(), is(OK.code())); + } + + private static Set<String> nodeNames(int count) { + return CLUSTER.runningNodes() + .map(Ignite::name) + .limit(count) + .collect(toSet()); + } + + private static MutableHttpRequest<?> restartPartitionsRequest( + Set<String> nodeNames, + String zoneName, + String tableName, + Collection<Integer> partitionIds + ) { + if (colocationEnabled()) { Review Comment: added test `testRestartTablePartitionsWithCleanupByNodes` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
