shishkovilja commented on code in PR #12201:
URL: https://github.com/apache/ignite/pull/12201#discussion_r2313702902
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java:
##########
@@ -49,35 +44,39 @@ public class GridNearAtomicUpdateResponse extends
GridCacheIdMessage implements
public static final int CACHE_MSG_IDX = nextIndexId();
/** Node ID this reply should be sent to. */
- @GridDirectTransient
private UUID nodeId;
/** Future ID. */
+ @Order(value = 4, method = "futureId")
private long futId;
/** */
+ @Order(value = 5, method = "errors")
private UpdateErrors errs;
/** Return value. */
@GridToStringInclude
+ @Order(value = 6, method = "returnValue")
private GridCacheReturn ret;
/** */
+ @Order(value = 7, method = "remapTopologyVersion")
private AffinityTopologyVersion remapTopVer;
/** Data for near cache update. */
+ @Order(8)
private NearCacheUpdates nearUpdates;
/** Partition ID. */
- private int partId = -1;
+ @Order(value = 9, method = "partition")
+ private int partId;
/** */
- @GridDirectCollection(UUID.class)
@GridToStringInclude
+ @Order(value = 10, method = "mapping")
Review Comment:
```suggestion
@Order(10)
```
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIdMessage.java:
##########
@@ -78,6 +81,7 @@ public void cacheId(int cacheId) {
/** {@inheritDoc} */
@Override public boolean readFrom(ByteBuffer buf, MessageReader reader) {
+ // TODO: Safe to remove only after all inheritors have migrated to the
new ser/der scheme (IGNITE-25490).
Review Comment:
The same with this comment.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIdMessage.java:
##########
@@ -52,6 +54,7 @@ public void cacheId(int cacheId) {
/** {@inheritDoc} */
@Override public boolean writeTo(ByteBuffer buf, MessageWriter writer) {
+ // TODO: Safe to remove only after all inheritors have migrated to the
new ser/der scheme (IGNITE-25490).
Review Comment:
May be we should move it to the method level or make comment more clear? Now
it points to next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
