sanpwc commented on code in PR #6513:
URL: https://github.com/apache/ignite-3/pull/6513#discussion_r2314283188
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/recovery/partitions/restart/ItRestartPartitionsTest.java:
##########
@@ -161,4 +164,51 @@ public void testRestartPartitionsPartitionsOutOfRange() {
DEFAULT_PARTITION_COUNT
));
}
+
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-26337";)
+ @Test
+ public void testRestartAllPartitionsWithCleanup() {
+ execute(CLUSTER_URL_OPTION, NODE_URL,
+ RECOVERY_TABLE_NAME_OPTION, QUALIFIED_TABLE_NAME,
+ RECOVERY_ZONE_NAME_OPTION, ZONE,
+ RECOVERY_WITH_CLEANUP_OPTION
+ );
+
+ assertErrOutputIsEmpty();
+ assertOutputContains("Successfully restarted partitions.");
+ }
+
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-26337";)
+ @Test
+ public void testRestartSpecifiedPartitionsWithCleanup() {
+ execute(CLUSTER_URL_OPTION, NODE_URL,
+ RECOVERY_TABLE_NAME_OPTION, QUALIFIED_TABLE_NAME,
+ RECOVERY_ZONE_NAME_OPTION, ZONE,
+ RECOVERY_PARTITION_IDS_OPTION, "1,2",
+ RECOVERY_WITH_CLEANUP_OPTION
+ );
+
+ assertErrOutputIsEmpty();
+ assertOutputContains("Successfully restarted partitions.");
+ }
+
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-26337";)
+ @Test
+ public void testRestartPartitionsByNodesWithCleanup() {
+ String nodeNames = CLUSTER.runningNodes()
+ .limit(initialNodes() - 1)
+ .map(Ignite::name)
+ .collect(joining(","));
+
+ execute(CLUSTER_URL_OPTION, NODE_URL,
+ RECOVERY_TABLE_NAME_OPTION, QUALIFIED_TABLE_NAME,
+ RECOVERY_ZONE_NAME_OPTION, ZONE,
+ RECOVERY_PARTITION_IDS_OPTION, "1,2",
+ RECOVERY_NODE_NAMES_OPTION, nodeNames,
Review Comment:
> does it make sense?
Yep, why node. And we definitely saw a bug related to this. I mean, that
currently recovery is considered as succeeded when it's finished on initiator
node only.
> The test makes recovery request from a node that is in nodeNames.
I'd rather add a test that will check that initiator node isn't in nodeNames
in addition to already existing one.
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/recovery/partitions/restart/ItRestartPartitionsTest.java:
##########
@@ -161,4 +164,51 @@ public void testRestartPartitionsPartitionsOutOfRange() {
DEFAULT_PARTITION_COUNT
));
}
+
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-26337";)
+ @Test
+ public void testRestartAllPartitionsWithCleanup() {
+ execute(CLUSTER_URL_OPTION, NODE_URL,
+ RECOVERY_TABLE_NAME_OPTION, QUALIFIED_TABLE_NAME,
+ RECOVERY_ZONE_NAME_OPTION, ZONE,
+ RECOVERY_WITH_CLEANUP_OPTION
+ );
+
+ assertErrOutputIsEmpty();
+ assertOutputContains("Successfully restarted partitions.");
+ }
+
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-26337";)
+ @Test
+ public void testRestartSpecifiedPartitionsWithCleanup() {
+ execute(CLUSTER_URL_OPTION, NODE_URL,
+ RECOVERY_TABLE_NAME_OPTION, QUALIFIED_TABLE_NAME,
+ RECOVERY_ZONE_NAME_OPTION, ZONE,
+ RECOVERY_PARTITION_IDS_OPTION, "1,2",
+ RECOVERY_WITH_CLEANUP_OPTION
+ );
+
+ assertErrOutputIsEmpty();
+ assertOutputContains("Successfully restarted partitions.");
+ }
+
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-26337";)
+ @Test
+ public void testRestartPartitionsByNodesWithCleanup() {
+ String nodeNames = CLUSTER.runningNodes()
+ .limit(initialNodes() - 1)
+ .map(Ignite::name)
+ .collect(joining(","));
+
+ execute(CLUSTER_URL_OPTION, NODE_URL,
+ RECOVERY_TABLE_NAME_OPTION, QUALIFIED_TABLE_NAME,
+ RECOVERY_ZONE_NAME_OPTION, ZONE,
+ RECOVERY_PARTITION_IDS_OPTION, "1,2",
+ RECOVERY_NODE_NAMES_OPTION, nodeNames,
Review Comment:
> does it make sense?
Yep, why node. And we definitely saw a bug related to this. I mean, that
currently recovery is considered as succeeded when it's finished on initiator
node only.
> The test makes recovery request from a node that is in nodeNames.
I'd rather add a test that will check that initiator node isn't in nodeNames
in addition to already existing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
