lowka commented on code in PR #6518: URL: https://github.com/apache/ignite-3/pull/6518#discussion_r2315292480
########## modules/jdbc/src/test/java/org/apache/ignite/internal/jdbc/JdbcResultSetBaseSelfTest.java: ########## @@ -0,0 +1,969 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.jdbc; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.any; +import static org.hamcrest.Matchers.containsString; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.io.InputStream; +import java.io.Reader; +import java.sql.Blob; +import java.sql.Clob; +import java.sql.Date; +import java.sql.NClob; +import java.sql.ResultSet; +import java.sql.ResultSetMetaData; +import java.sql.SQLException; +import java.sql.SQLFeatureNotSupportedException; +import java.sql.Time; +import java.sql.Timestamp; +import java.time.ZoneId; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Calendar; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import org.apache.ignite.internal.testframework.BaseIgniteAbstractTest; +import org.apache.ignite.sql.ColumnType; +import org.jetbrains.annotations.Nullable; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; + +/** + * Compatibility tests to ensure that both JDBC result set adapters behave identically for core java.sql.ResultSet methods (excluding + * metadata checks). + */ +public abstract class JdbcResultSetBaseSelfTest extends BaseIgniteAbstractTest { + + private static final Calendar CALENDAR = Calendar.getInstance(); + + protected abstract ResultSet createResultSet( + @Nullable ZoneId zoneId, + List<ColumnDefinition> cols, + List<List<Object>> rows + ) throws SQLException; + + protected final ResultSet createPositionedSingle(ColumnDefinition col, Object value) throws SQLException { + return createPositionedMulti(new ColumnDefinition[]{col}, new Object[]{value}); + } + + private ResultSet createPositionedMulti(@Nullable ZoneId zoneId, ColumnDefinition[] columns, Object[] values) throws SQLException { + if (columns.length != values.length) { + throw new IllegalArgumentException("cols, values must have the same length"); + } + + List<ColumnDefinition> cols = Arrays.asList(columns); + List<List<Object>> rows = new ArrayList<>(); + rows.add(Arrays.asList(values)); + + ResultSet rs = createResultSet(zoneId, cols, rows); + assertTrue(rs.next()); + return rs; + } + + private ResultSet createPositionedMulti(ColumnDefinition[] columns, Object[] values) throws SQLException { + return createPositionedMulti(null, columns, values); + } + + @Test + public void getNotSupportedTypes() throws SQLException { + try (ResultSet rs = createPositionedSingle(new ColumnDefinition("C", ColumnType.STRING, 3, 0, false), "ABC")) { + + expectNotSupported(() -> rs.getArray(1)); + expectNotSupported(() -> rs.getArray("C")); + + expectNotSupported(() -> rs.getAsciiStream(1)); + expectNotSupported(() -> rs.getAsciiStream("C")); + + expectNotSupported(() -> rs.getBinaryStream(1)); + expectNotSupported(() -> rs.getBinaryStream("C")); + + expectNotSupported(() -> rs.getBlob(1)); + expectNotSupported(() -> rs.getBlob("C")); + + expectNotSupported(() -> rs.getClob(1)); + expectNotSupported(() -> rs.getClob("C")); + + expectNotSupported(() -> rs.getCharacterStream(1)); + expectNotSupported(() -> rs.getCharacterStream("C")); + + expectNotSupported(() -> rs.getNCharacterStream(1)); + expectNotSupported(() -> rs.getNCharacterStream("C")); + + expectNotSupported(() -> rs.getNClob(1)); + expectNotSupported(() -> rs.getNClob("C")); + + expectNotSupported(() -> rs.getRef(1)); + expectNotSupported(() -> rs.getRef("C")); + + expectNotSupported(() -> rs.getRowId(1)); + expectNotSupported(() -> rs.getRowId("C")); + + expectNotSupported(() -> rs.getSQLXML(1)); + expectNotSupported(() -> rs.getSQLXML("C")); + + expectNotSupported(() -> rs.getObject(1, Map.of())); + expectNotSupported(() -> rs.getObject("C", Map.of())); + } + } + + @Test + public void updateMethodsAreNotSupported() throws Exception { + try (ResultSet rs = createPositionedSingle(new ColumnDefinition("C", ColumnType.STRING, 3, 0, false), "ABC")) { + + expectNotSupported(() -> rs.updateBoolean(1, true)); + expectNotSupported(() -> rs.updateBoolean("C", true)); + + expectNotSupported(() -> rs.updateByte(1, (byte) 0)); + expectNotSupported(() -> rs.updateByte("C", (byte) 0)); + + expectNotSupported(() -> rs.updateShort(1, (short) 0)); + expectNotSupported(() -> rs.updateShort("C", (short) 0)); + + expectNotSupported(() -> rs.updateInt(1, 0)); + expectNotSupported(() -> rs.updateInt("C", 0)); + + expectNotSupported(() -> rs.updateLong(1, 0)); + expectNotSupported(() -> rs.updateLong("C", 0)); + + expectNotSupported(() -> rs.updateFloat(1, (float) 0.0)); + expectNotSupported(() -> rs.updateFloat("C", (float) 0.0)); + + expectNotSupported(() -> rs.updateDouble(1, 0.0)); + expectNotSupported(() -> rs.updateDouble("C", 0.0)); + + expectNotSupported(() -> rs.updateString(1, "")); + expectNotSupported(() -> rs.updateString("C", "")); + + expectNotSupported(() -> rs.updateTime(1, new Time(0))); + expectNotSupported(() -> rs.updateTime("C", new Time(0))); + + expectNotSupported(() -> rs.updateDate(1, new Date(0))); + expectNotSupported(() -> rs.updateDate("C", new Date(0))); + + expectNotSupported(() -> rs.updateTimestamp(1, new Timestamp(0))); + expectNotSupported(() -> rs.updateTimestamp("C", new Timestamp(0))); + + expectNotSupported(() -> rs.updateBytes(1, new byte[]{1})); + expectNotSupported(() -> rs.updateBytes("C", new byte[]{1})); + + expectNotSupported(() -> rs.updateArray(1, null)); + expectNotSupported(() -> rs.updateArray("C", null)); + + expectNotSupported(() -> rs.updateBlob(1, (Blob) null)); + expectNotSupported(() -> rs.updateBlob(1, (InputStream) null)); + expectNotSupported(() -> rs.updateBlob(1, null, 0L)); + expectNotSupported(() -> rs.updateBlob("C", (Blob) null)); + expectNotSupported(() -> rs.updateBlob("C", (InputStream) null)); + expectNotSupported(() -> rs.updateBlob("C", null, 0L)); + + expectNotSupported(() -> rs.updateClob(1, (Clob) null)); + expectNotSupported(() -> rs.updateClob(1, (Reader) null)); + expectNotSupported(() -> rs.updateClob(1, null, 0L)); + expectNotSupported(() -> rs.updateClob("C", (Clob) null)); + expectNotSupported(() -> rs.updateClob("C", (Reader) null)); + expectNotSupported(() -> rs.updateClob("C", null, 0L)); + + expectNotSupported(() -> rs.updateNClob(1, (NClob) null)); + expectNotSupported(() -> rs.updateNClob(1, (Reader) null)); + expectNotSupported(() -> rs.updateNClob(1, null, 0L)); + expectNotSupported(() -> rs.updateNClob("C", (NClob) null)); + expectNotSupported(() -> rs.updateNClob("C", (Reader) null)); + expectNotSupported(() -> rs.updateNClob("C", null, 0L)); + + expectNotSupported(() -> rs.updateAsciiStream(1, null)); + expectNotSupported(() -> rs.updateAsciiStream(1, null, 0)); + expectNotSupported(() -> rs.updateAsciiStream(1, null, 0L)); + expectNotSupported(() -> rs.updateAsciiStream("C", null)); + expectNotSupported(() -> rs.updateAsciiStream("C", null, 0)); + expectNotSupported(() -> rs.updateAsciiStream("C", null, 0L)); + + expectNotSupported(() -> rs.updateBinaryStream(1, null)); + expectNotSupported(() -> rs.updateBinaryStream(1, null, 0)); + expectNotSupported(() -> rs.updateBinaryStream(1, null, 0L)); + expectNotSupported(() -> rs.updateBinaryStream("C", null)); + expectNotSupported(() -> rs.updateBinaryStream("C", null, 0)); + expectNotSupported(() -> rs.updateBinaryStream("C", null, 0L)); + + expectNotSupported(() -> rs.updateCharacterStream(1, null)); + expectNotSupported(() -> rs.updateCharacterStream(1, null, 0)); + expectNotSupported(() -> rs.updateCharacterStream(1, null, 0L)); + expectNotSupported(() -> rs.updateCharacterStream("C", null)); + expectNotSupported(() -> rs.updateCharacterStream("C", null, 0)); + expectNotSupported(() -> rs.updateCharacterStream("C", null, 0L)); + + expectNotSupported(() -> rs.updateNCharacterStream(1, null)); + expectNotSupported(() -> rs.updateNCharacterStream(1, null, 0)); + expectNotSupported(() -> rs.updateNCharacterStream(1, null, 0L)); + expectNotSupported(() -> rs.updateNCharacterStream("C", null)); + expectNotSupported(() -> rs.updateNCharacterStream("C", null, 0)); + expectNotSupported(() -> rs.updateNCharacterStream("C", null, 0L)); + + expectNotSupported(() -> rs.updateRef(1, null)); + expectNotSupported(() -> rs.updateRef("C", null)); + + expectNotSupported(() -> rs.updateRowId(1, null)); + expectNotSupported(() -> rs.updateRowId("C", null)); + + expectNotSupported(() -> rs.updateNString(1, null)); + expectNotSupported(() -> rs.updateNString("C", null)); + + expectNotSupported(() -> rs.updateSQLXML(1, null)); + expectNotSupported(() -> rs.updateSQLXML("C", null)); + + expectNotSupported(() -> rs.updateObject(1, null)); + expectNotSupported(() -> rs.updateObject(1, null, 0)); + expectNotSupported(() -> rs.updateObject("C", null)); + expectNotSupported(() -> rs.updateObject("C", null, 0)); + + expectNotSupported(() -> rs.updateBigDecimal(1, null)); + expectNotSupported(() -> rs.updateBigDecimal("C", null)); + + expectNotSupported(() -> rs.updateNull(1)); + expectNotSupported(() -> rs.updateNull("C")); + + expectNotSupported(rs::cancelRowUpdates); + + expectNotSupported(rs::updateRow); + + expectNotSupported(rs::deleteRow); + + expectNotSupported(rs::insertRow); + + expectNotSupported(rs::moveToInsertRow); + } + } + + @Test + public void navigationMethods() throws SQLException { + try (ResultSet rs = createResultSet(null, + List.of(new ColumnDefinition("C", ColumnType.STRING, 3, 0, false)), + List.of(List.of("A"), List.of("B"))) + ) { + assertTrue(rs.isBeforeFirst()); + assertFalse(rs.isAfterLast()); + assertFalse(rs.isFirst()); + assertFalse(rs.isLast()); + assertEquals(0, rs.getRow()); + + assertTrue(rs.next()); + + assertFalse(rs.isBeforeFirst()); + assertFalse(rs.isAfterLast()); + assertTrue(rs.isFirst()); + assertFalse(rs.isLast()); + assertEquals(1, rs.getRow()); + + assertTrue(rs.next()); + + assertFalse(rs.isBeforeFirst()); + assertFalse(rs.isAfterLast()); + assertFalse(rs.isFirst()); + assertTrue(rs.isLast()); + assertEquals(2, rs.getRow()); + + assertFalse(rs.next()); + + assertFalse(rs.isBeforeFirst()); + assertTrue(rs.isAfterLast()); + assertFalse(rs.isFirst()); + assertFalse(rs.isLast()); + assertEquals(0, rs.getRow()); + } + + try (ResultSet rs = createResultSet(null, + List.of(new ColumnDefinition("C", ColumnType.STRING, 3, 0, false)), + List.of(List.of("A"), List.of("B"))) + ) { + String error = "Result set is forward-only."; + + expectSqlException(rs::first, error); + expectSqlException(rs::afterLast, error); + expectSqlException(rs::last, error); + + assertTrue(rs.next()); + + expectSqlException(rs::first, error); + expectSqlException(rs::afterLast, error); + expectSqlException(rs::last, error); + + expectSqlException(() -> rs.absolute(0), error); + expectSqlException(() -> rs.relative(0), error); + expectSqlException(rs::previous, error); + + assertEquals(ResultSet.FETCH_FORWARD, rs.getFetchDirection()); + rs.setFetchDirection(ResultSet.FETCH_FORWARD); + assertEquals(ResultSet.FETCH_FORWARD, rs.getFetchDirection()); + + assertEquals(ResultSet.CONCUR_READ_ONLY, rs.getConcurrency()); + assertEquals(ResultSet.TYPE_FORWARD_ONLY, rs.getType()); + assertEquals(ResultSet.HOLD_CURSORS_OVER_COMMIT, rs.getHoldability()); + + expectSqlException(rs::moveToCurrentRow, "The result set concurrency is CONCUR_READ_ONLY"); + } + } + + @ParameterizedTest + @EnumSource(names = {"PERIOD", "DURATION"}, mode = EnumSource.Mode.EXCLUDE) + public void wasNullPositional(ColumnType columnType) throws SQLException { + try (ResultSet rs = createPositionedSingle(new ColumnDefinition("C", columnType, 0, 0, false), null)) { + switch (columnType) { + case NULL: + assertNull(rs.getObject(1)); + assertTrue(rs.wasNull()); + break; + case BOOLEAN: + assertFalse(rs.getBoolean(1)); + assertTrue(rs.wasNull()); + break; + case INT8: + assertEquals(0, rs.getByte(1)); + assertTrue(rs.wasNull()); + break; + case INT16: + assertEquals(0, rs.getShort(1)); + assertTrue(rs.wasNull()); + break; + case INT32: + assertEquals(0, rs.getInt(1)); + assertTrue(rs.wasNull()); + break; + case INT64: + assertEquals(0, rs.getLong(1)); + assertTrue(rs.wasNull()); + break; + case FLOAT: + assertEquals(0, rs.getFloat(1)); + assertTrue(rs.wasNull()); + break; + case DOUBLE: + assertEquals(0, rs.getDouble(1)); + assertTrue(rs.wasNull()); + break; + case DECIMAL: + assertNull(rs.getBigDecimal(1)); + assertTrue(rs.wasNull()); + break; + case DATE: + assertNull(rs.getDate(1)); + assertTrue(rs.wasNull()); + break; + case TIME: + assertNull(rs.getTime(1)); + assertTrue(rs.wasNull()); + break; + case DATETIME: + assertNull(rs.getTimestamp(1)); + assertTrue(rs.wasNull()); + break; + case TIMESTAMP: + assertNull(rs.getTimestamp(1)); + assertTrue(rs.wasNull()); + break; + case UUID: + assertNull(rs.getObject(1, UUID.class)); + assertTrue(rs.wasNull()); + break; + case STRING: + assertNull(rs.getString(1)); + assertTrue(rs.wasNull()); + break; + case BYTE_ARRAY: + assertNull(rs.getBytes(1)); + assertTrue(rs.wasNull()); + break; + default: + throw new IllegalArgumentException("Unexpected type: " + columnType); + } + } + } + + @ParameterizedTest + @EnumSource(names = {"PERIOD", "DURATION"}, mode = EnumSource.Mode.EXCLUDE) + public void wasNullNamed(ColumnType columnType) throws SQLException { + try (ResultSet rs = createPositionedSingle(new ColumnDefinition("C", columnType, 0, 0, false), null)) { + switch (columnType) { + case NULL: + assertNull(rs.getObject("C")); + assertTrue(rs.wasNull()); + break; + case BOOLEAN: + assertFalse(rs.getBoolean("C")); + assertTrue(rs.wasNull()); + break; + case INT8: + assertEquals(0, rs.getByte("C")); + assertTrue(rs.wasNull()); + break; + case INT16: + assertEquals(0, rs.getShort("C")); + assertTrue(rs.wasNull()); + break; + case INT32: + assertEquals(0, rs.getInt("C")); + assertTrue(rs.wasNull()); + break; + case INT64: + assertEquals(0, rs.getLong("C")); + assertTrue(rs.wasNull()); + break; + case FLOAT: + assertEquals(0, rs.getFloat("C")); + assertTrue(rs.wasNull()); + break; + case DOUBLE: + assertEquals(0, rs.getDouble("C")); + assertTrue(rs.wasNull()); + break; + case DECIMAL: + assertNull(rs.getBigDecimal("C")); + assertTrue(rs.wasNull()); + break; + case DATE: + assertNull(rs.getDate("C")); + assertTrue(rs.wasNull()); + break; + case TIME: + assertNull(rs.getTime("C")); + assertTrue(rs.wasNull()); + break; + case DATETIME: + assertNull(rs.getTimestamp("C")); + assertTrue(rs.wasNull()); + break; + case TIMESTAMP: + assertNull(rs.getTimestamp("C")); + assertTrue(rs.wasNull()); + break; + case UUID: + assertNull(rs.getObject(1, UUID.class)); + assertTrue(rs.wasNull()); + break; + case STRING: + assertNull(rs.getString("C")); + assertTrue(rs.wasNull()); + break; + case BYTE_ARRAY: + assertNull(rs.getBytes("C")); + assertTrue(rs.wasNull()); + break; + default: + throw new IllegalArgumentException("Unexpected type: " + columnType); + } + } + } + + @Test + public void getUnknownColumn() throws SQLException { + try (ResultSet rs = createPositionedSingle(new ColumnDefinition("C", ColumnType.BOOLEAN, 0, 0, false), 1)) { + + expectInvalidColumn(rs::getBoolean, -1); + expectInvalidColumn(rs::getBoolean, 2); + expectInvalidColumn(rs::getBoolean, "X"); + + expectInvalidColumn(rs::getByte, -1); + expectInvalidColumn(rs::getByte, 2); + expectInvalidColumn(rs::getByte, "X"); + + expectInvalidColumn(rs::getShort, -1); + expectInvalidColumn(rs::getShort, 2); + expectInvalidColumn(rs::getShort, "X"); + + expectInvalidColumn(rs::getInt, -1); + expectInvalidColumn(rs::getInt, 2); + expectInvalidColumn(rs::getInt, "X"); + + expectInvalidColumn(rs::getLong, -1); + expectInvalidColumn(rs::getLong, 2); + expectInvalidColumn(rs::getLong, "X"); + + expectInvalidColumn(rs::getFloat, -1); + expectInvalidColumn(rs::getFloat, 2); + expectInvalidColumn(rs::getFloat, "X"); + + expectInvalidColumn(rs::getDouble, -1); + expectInvalidColumn(rs::getDouble, 2); + expectInvalidColumn(rs::getDouble, "X"); + + expectInvalidColumn(rs::getBigDecimal, -1); + expectInvalidColumn(rs::getBigDecimal, 2); + expectInvalidColumn(rs::getBigDecimal, "X"); + + expectInvalidColumn(rs::getDate, -1); + expectInvalidColumn(rs::getDate, 2); + expectInvalidColumn(rs::getDate, "X"); + + expectInvalidColumn(rs::getTime, -1); + expectInvalidColumn(rs::getTime, 2); + expectInvalidColumn(rs::getTime, "X"); + + expectInvalidColumn(rs::getTimestamp, -1); + expectInvalidColumn(rs::getTimestamp, 2); + expectInvalidColumn(rs::getTimestamp, "X"); + + expectInvalidColumn(rs::getString, -1); + expectInvalidColumn(rs::getString, 2); + expectInvalidColumn(rs::getString, "X"); + + expectInvalidColumn(rs::getNString, -1); + expectInvalidColumn(rs::getNString, 2); + expectInvalidColumn(rs::getNString, "X"); + + expectInvalidColumn(rs::getObject, -1); + expectInvalidColumn(rs::getObject, 2); + expectInvalidColumn(rs::getObject, "X"); + + expectSqlException(() -> rs.getObject(-1, Integer.class), "Invalid column index: -1"); + expectSqlException(() -> rs.getObject(2, Integer.class), "Invalid column index: 2"); + expectSqlException(() -> rs.getObject("X", Integer.class), "Column not found: X"); + + expectSqlException(() -> rs.getObject(-1, Map.of()), "SQL structured type are not supported"); + expectSqlException(() -> rs.getObject(2, Map.of()), "SQL structured type are not supported"); + expectSqlException(() -> rs.getObject("X", Map.of()), "SQL structured type are not supported"); + } + } + + @Test + public void methodsArePositioned() throws SQLException { + try (ResultSet rs = createResultSet(null, + List.of(new ColumnDefinition("C", ColumnType.BOOLEAN, 0, 0, false)), + List.of()) + ) { + expectPositioned(rs::wasNull); + + expectPositioned(() -> rs.getBoolean(1)); + expectPositioned(() -> rs.getBoolean("C")); + + expectPositioned(() -> rs.getByte(1)); + expectPositioned(() -> rs.getByte("C")); + + expectPositioned(() -> rs.getShort(1)); + expectPositioned(() -> rs.getShort("C")); + + expectPositioned(() -> rs.getInt(1)); + expectPositioned(() -> rs.getInt("C")); + + expectPositioned(() -> rs.getLong(1)); + expectPositioned(() -> rs.getLong("C")); + + expectPositioned(() -> rs.getFloat(1)); + expectPositioned(() -> rs.getFloat("C")); + + expectPositioned(() -> rs.getDouble(1)); + expectPositioned(() -> rs.getDouble("C")); + + expectPositioned(() -> rs.getBigDecimal(1)); + expectPositioned(() -> rs.getBigDecimal("C")); + + expectPositioned(() -> rs.getBigDecimal(1, 2)); + expectPositioned(() -> rs.getBigDecimal("C", 3)); + + expectPositioned(() -> rs.getDate(1)); + expectPositioned(() -> rs.getDate("C")); + + expectPositioned(() -> rs.getTime(1)); + expectPositioned(() -> rs.getTime("C")); + + expectPositioned(() -> rs.getTimestamp(1)); + expectPositioned(() -> rs.getTimestamp("C")); + + expectPositioned(() -> rs.getString(1)); + expectPositioned(() -> rs.getString("C")); + + expectPositioned(() -> rs.getNString(1)); + expectPositioned(() -> rs.getNString("C")); + + expectPositioned(() -> rs.getObject(1)); + expectPositioned(() -> rs.getObject("C")); + + expectPositioned(() -> rs.getObject(1, Boolean.class)); + expectPositioned(() -> rs.getObject("C", Boolean.class)); + + expectPositioned(() -> rs.getBytes(1)); + expectPositioned(() -> rs.getBytes("C")); + + expectPositioned(() -> rs.getURL(1)); + expectPositioned(() -> rs.getURL("C")); + + assertNotNull(rs.getMetaData()); Review Comment: Fixed, added a comment that says that other methods can be called on a result set that has not been positioned yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
