dant3 commented on code in PR #6540:
URL: https://github.com/apache/ignite-3/pull/6540#discussion_r2318462486
##########
modules/compatibility-tests/build.gradle:
##########
@@ -78,11 +79,13 @@ private def resolveAllDependencies(String...
dependencyNotations) {
return detached.resolve() // Set<File> of *.jar
}
+def versionsJsonFileName = 'src/testFixtures/resources/igniteVersions.json'
+
// This task resolves dependencies described in the file making them cached
locally. If testAllVersions system property is not defined or is
// not equals to `true`, at most 2 last versions are resolved
def resolveCompatibilityTestDependencies =
tasks.register('resolveCompatibilityTestDependencies') {
doLast {
- def versionsFile =
file('src/testFixtures/resources/igniteVersions.json')
+ def versionsFile = file(versionsJsonFileName)
Review Comment:
its worth to declare this file, and property hidden under
`shouldTestAllVersions()` as an inputs of this task
##########
modules/compatibility-tests/build.gradle:
##########
@@ -152,3 +155,21 @@ tasks.register('runnerPlatformCompatibilityTest',
JavaExec) {
enableAssertions = true
}
+
+tasks.register('postRelease', Copy) {
+ // Copy current OpenAPI specification to resources
+ from configurations.openapiSpec
+ into
file("src/test/resources/versions/${project.projectVersion.toString().replace('.',
'_')}/")
Review Comment:
lets not replace dots in the version name here, since we will have to do
this everywhere else and for no real reason that is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
