Phillippko commented on code in PR #6538:
URL: https://github.com/apache/ignite-3/pull/6538#discussion_r2318785922
##########
modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeTestEmbedded.java:
##########
@@ -186,10 +186,12 @@ void shouldNotConvertIgniteException() {
IgniteException exception = new IgniteException(INTERNAL_ERR, "Test
exception");
CustomFailingJob.th = exception;
- IgniteException ex = assertThrows(IgniteException.class, () ->
entryNode.compute().execute(
- JobTarget.node(clusterNode(entryNode)),
-
JobDescriptor.builder(CustomFailingJob.class).units(units()).build(),
- null));
+ IgniteException ex = assertThrows(IgniteException.class, () -> {
Review Comment:
same
##########
modules/distribution-zones/tech-notes/images/flow.svg:
##########
Review Comment:
something happened to these images
##########
modules/network-api/src/main/java/org/apache/ignite/internal/network/InternalClusterNode.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.network;
+
+import java.util.UUID;
+import org.apache.ignite.network.NetworkAddress;
+import org.apache.ignite.network.NodeMetadata;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Representation of a node in a cluster.
+ */
+public interface InternalClusterNode {
+ /**
+ * Returns the node's local ID.
+ *
+ * @return Node's local ID.
+ */
+ UUID id();
+
+ /**
+ * Returns the unique name (consistent ID) of the node in the cluster.
Does not change between restarts.
+ *
+ * @return Unique name of a cluster member.
+ */
+ String name();
+
+ /**
+ * Returns the network address of the node.
+ *
+ * @return Network address of the node.
+ */
+ NetworkAddress address();
+
+ /**
+ * Returns the metadata of the node.
+ *
+ * @return Metadata of the node.
+ */
+ @Nullable
+ NodeMetadata nodeMetadata();
+
+ /**
+ * Converts this node to its public representation.
+ */
+ org.apache.ignite.network.ClusterNode asPublicNode();
Review Comment:
```suggestion
ClusterNode asPublicNode();
```
##########
modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeBaseTest.java:
##########
@@ -802,10 +820,14 @@ private static Stream<Arguments> tupleCollections() {
}
@Test
- void partitionedBroadcast() {
+ void partitionedBroadcast() throws Exception {
createTestTableWithOneRow();
- Map<Partition, ClusterNode> replicas =
node(0).tables().table("test").partitionManager().primaryReplicasAsync().join();
+ Map<Partition, ClusterNode> replicas = node(0).tables()
Review Comment:
Are all changes in this file intentional? They don't seem connected to the
ticket
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/IgniteComputeImpl.java:
##########
@@ -266,6 +270,16 @@ public <T, R> CompletableFuture<BroadcastExecution<R>>
submitAsync(
throw new IllegalArgumentException("Unsupported job target: " +
target);
}
+ private static Set<InternalClusterNode>
internalNodesFromPublicNodes(Set<ClusterNode> nodes) {
+ return nodes.stream()
+ .map(InternalClusterNodeImpl::fromPublicClusterNode)
+ .collect(Collectors.toSet());
+ }
+
+ private @Nullable InternalClusterNode findNodeByConsistentId(ClusterNode
clusterNode) {
Review Comment:
byConsistentId - but we pass clusterNode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
