Phillippko commented on code in PR #6603:
URL: https://github.com/apache/ignite-3/pull/6603#discussion_r2358006088
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/util/AsciiStringUtil.java:
##########
@@ -16,19 +16,18 @@
*/
package org.apache.ignite.raft.jraft.util;
+import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
/**
*
*/
public final class AsciiStringUtil {
-
- public static byte[] unsafeEncode(final CharSequence in, byte[] out, int
offset) {
Review Comment:
this class is in jraft package, should we add a method instead of replacing
it? In case we will need to merge something from upstream. TBH I don't know our
best practices of changing jraft code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
