zstan commented on code in PR #6593:
URL: https://github.com/apache/ignite-3/pull/6593#discussion_r2358503106


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/cache/Cache.java:
##########
@@ -93,4 +95,12 @@ public interface Cache<K, V> {
      * @return The number of entries in the cache.
      */
     int size();
+

Review Comment:
   i found that but seems i still need "entrySet" and "computeIfPresent" from 
cache side, thus - changes still present



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java:
##########
@@ -77,6 +94,9 @@ public boolean equals(Object o) {
         if (!schemaName.equals(cacheKey.schemaName)) {
             return false;
         }
+        if (queryType != cacheKey.queryType) {
+            return false;

Review Comment:
   changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to