timoninmaxim commented on code in PR #12377: URL: https://github.com/apache/ignite/pull/12377#discussion_r2414828804
########## modules/core/src/main/java/org/apache/ignite/internal/managers/communication/ErrorMessage.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.managers.communication; + +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.IgniteException; +import org.apache.ignite.internal.MessageProcessor; +import org.apache.ignite.internal.Order; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.marshaller.jdk.JdkMarshaller; +import org.apache.ignite.plugin.extensions.communication.Message; + +import static org.apache.ignite.marshaller.Marshallers.jdk; + +/** + * Message used to transfer {@link Throwable} objects. + * <p>Because raw serialization of throwables is prohibited, you should use this message when it is necessary + * to transfer some error as part of some message. See {@link MessageProcessor} for details. + * <p>Currently, under the hood marshalling and unmarshalling is performed by {@link JdkMarshaller}. + */ +@SuppressWarnings("AssignmentOrReturnOfFieldWithMutableType") +public class ErrorMessage implements Message { + /** Serialized form of throwable. */ + @Order(value = 0, method = "errorBytes") + private byte[] errBytes; + + /** Original error. It is transient and necessary only to avoid duplicated serialization and deserializtion. */ + private Throwable err; Review Comment: nullable ########## modules/core/src/main/java/org/apache/ignite/internal/managers/communication/ErrorMessage.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.managers.communication; + +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.IgniteException; +import org.apache.ignite.internal.MessageProcessor; +import org.apache.ignite.internal.Order; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.marshaller.jdk.JdkMarshaller; +import org.apache.ignite.plugin.extensions.communication.Message; + +import static org.apache.ignite.marshaller.Marshallers.jdk; + +/** + * Message used to transfer {@link Throwable} objects. + * <p>Because raw serialization of throwables is prohibited, you should use this message when it is necessary + * to transfer some error as part of some message. See {@link MessageProcessor} for details. + * <p>Currently, under the hood marshalling and unmarshalling is performed by {@link JdkMarshaller}. + */ +@SuppressWarnings("AssignmentOrReturnOfFieldWithMutableType") +public class ErrorMessage implements Message { + /** Serialized form of throwable. */ + @Order(value = 0, method = "errorBytes") + private byte[] errBytes; + + /** Original error. It is transient and necessary only to avoid duplicated serialization and deserializtion. */ + private Throwable err; + + /** + * Default constructor. + */ + public ErrorMessage() { + // No-op. + } + + /** + * @param err Original error. Will be lazily serialized. + */ + public ErrorMessage(Throwable err) { + this.err = err; + } + + /** + * @return Serialized form of throwable. + */ + public byte[] errorBytes() { + return bytesFromThrowable(); + } + + /** + * @param errBytes New serialized form of throwable. + */ + public void errorBytes(byte[] errBytes) { + this.errBytes = errBytes; + } + + /** + * Gets serialized error. + */ + private byte[] bytesFromThrowable() { + try { + if (errBytes == null) + errBytes = U.marshal(jdk(), err); Review Comment: what if `err == null`? ########## modules/core/src/main/java/org/apache/ignite/internal/managers/communication/ErrorMessage.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.managers.communication; + +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.IgniteException; +import org.apache.ignite.internal.MessageProcessor; +import org.apache.ignite.internal.Order; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.marshaller.jdk.JdkMarshaller; +import org.apache.ignite.plugin.extensions.communication.Message; + +import static org.apache.ignite.marshaller.Marshallers.jdk; + +/** + * Message used to transfer {@link Throwable} objects. + * <p>Because raw serialization of throwables is prohibited, you should use this message when it is necessary + * to transfer some error as part of some message. See {@link MessageProcessor} for details. + * <p>Currently, under the hood marshalling and unmarshalling is performed by {@link JdkMarshaller}. + */ +@SuppressWarnings("AssignmentOrReturnOfFieldWithMutableType") +public class ErrorMessage implements Message { + /** Serialized form of throwable. */ + @Order(value = 0, method = "errorBytes") + private byte[] errBytes; + + /** Original error. It is transient and necessary only to avoid duplicated serialization and deserializtion. */ + private Throwable err; + + /** + * Default constructor. + */ + public ErrorMessage() { + // No-op. + } + + /** + * @param err Original error. Will be lazily serialized. + */ + public ErrorMessage(Throwable err) { + this.err = err; + } + + /** + * @return Serialized form of throwable. + */ + public byte[] errorBytes() { + return bytesFromThrowable(); + } + + /** + * @param errBytes New serialized form of throwable. + */ + public void errorBytes(byte[] errBytes) { + this.errBytes = errBytes; + } + + /** + * Gets serialized error. + */ + private byte[] bytesFromThrowable() { + try { + if (errBytes == null) + errBytes = U.marshal(jdk(), err); + + return errBytes; + } + catch (IgniteCheckedException e) { + throw new IgniteException(e); + } + } + + /** + * @return Original {@link Throwable}. + */ + public Throwable toThrowable() { + try { + if (err == null) { + err = U.unmarshal(jdk(), errBytes, U.gridClassLoader()); Review Comment: NPE if errBytes is null ########## modules/core/src/main/java/org/apache/ignite/internal/managers/communication/ErrorMessage.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.managers.communication; + +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.IgniteException; +import org.apache.ignite.internal.MessageProcessor; +import org.apache.ignite.internal.Order; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.marshaller.jdk.JdkMarshaller; +import org.apache.ignite.plugin.extensions.communication.Message; + +import static org.apache.ignite.marshaller.Marshallers.jdk; + +/** + * Message used to transfer {@link Throwable} objects. + * <p>Because raw serialization of throwables is prohibited, you should use this message when it is necessary + * to transfer some error as part of some message. See {@link MessageProcessor} for details. + * <p>Currently, under the hood marshalling and unmarshalling is performed by {@link JdkMarshaller}. + */ +@SuppressWarnings("AssignmentOrReturnOfFieldWithMutableType") +public class ErrorMessage implements Message { + /** Serialized form of throwable. */ + @Order(value = 0, method = "errorBytes") + private byte[] errBytes; + + /** Original error. It is transient and necessary only to avoid duplicated serialization and deserializtion. */ + private Throwable err; + + /** + * Default constructor. + */ + public ErrorMessage() { + // No-op. + } + + /** + * @param err Original error. Will be lazily serialized. + */ + public ErrorMessage(Throwable err) { + this.err = err; + } + + /** + * @return Serialized form of throwable. + */ + public byte[] errorBytes() { + return bytesFromThrowable(); Review Comment: can be inlined -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
