Cyrill commented on code in PR #6722:
URL: https://github.com/apache/ignite-3/pull/6722#discussion_r2426574780
##########
modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/AssignmentsQueueSerializer.java:
##########
@@ -40,6 +42,14 @@ protected void writeExternalData(AssignmentsQueue queue,
IgniteDataOutput out) t
@Override
protected AssignmentsQueue readExternalData(byte protoVer, IgniteDataInput
in) throws IOException {
+ if (protoVer == 1) {
Review Comment:
Yes, some previously built 3.0-snapshot artifacts will fail, but I don't see
a better option to maintain 3.0/3.1 compatibility in this code.
Surely we could try treading AssignmentsQueue and in the case of failure -
try rereading the same bytes as Assignments, but it will be much more
cumbersome code like using mark/reset of an InputStream or double buffering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
